You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/08/02 08:07:56 UTC

[GitHub] [cloudstack] GutoVeronezi opened a new pull request, #6341: Enable system VM volume migration for KVM

GutoVeronezi opened a new pull request, #6341:
URL: https://github.com/apache/cloudstack/pull/6341

   ### Description
   
   Release 4.16.0.0 introduced a feature for migrating system VM volumes (#4385). However, it was enabled only for VMWare.
   
   This PR intends to enable the feature for KVM too.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ x] Minor
   
   ### How Has This Been Tested?
   
   It was tested in a local lab.
   
   (I tested the process for each system VM type)
   
   To test the SSVM and CPVM, I enabled a zone to create them. When they were created, I disabled the zone. I accessed the system VMs and created files to validate later. I stopped them and migrated the volumes. I checked the references in database and storage and then I started the system VMs. After that, I accessed them again and verified the files. The migration performed successfully, the data was kept and the system VMs were working fine.
   
   To test the VR, I created a network. I accessed the VR and created a file to validate later. I stopped the VR and migrated the volume. I checked the reference in database and storage and then I started the VR. After that, I accessed it again and verified the file. The migration performed successfully, the data was kept and the VR was working fine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] shwstppr closed pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #6341: Enable system VM volume migration for KVM
URL: https://github.com/apache/cloudstack/pull/6341


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1203005823

   @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] shwstppr commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1207669927

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland closed pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #6341: Enable system VM volume migration for KVM
URL: https://github.com/apache/cloudstack/pull/6341


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1175486096

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6341)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6341&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6341&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6341&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=CODE_SMELL)
   
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6341&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6341&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6341&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6341&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1202151020

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3880


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] shwstppr commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1202230219

   After fixing schema, tested both inter and intra-cluster storage migration for a VR and it worked successfully


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1202393539

   <b>Trillian test result (tid-4595)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 12727 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6341-t4595-kvm-centos7.zip
   Smoke tests completed. 46 look OK, 55 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestLBRuleUsage>:setup | `Error` | 6.91 | test_usage.py
   ContextSuite context=TestNatRuleUsage>:setup | `Error` | 13.68 | test_usage.py
   ContextSuite context=TestPublicIPUsage>:setup | `Error` | 19.45 | test_usage.py
   ContextSuite context=TestSnapshotUsage>:setup | `Error` | 25.21 | test_usage.py
   ContextSuite context=TestVmUsage>:setup | `Error` | 45.01 | test_usage.py
   ContextSuite context=TestVolumeUsage>:setup | `Error` | 51.83 | test_usage.py
   ContextSuite context=TestVpnUsage>:setup | `Error` | 57.69 | test_usage.py
   test_01_vpc_privategw_acl | `Failure` | 5.82 | test_privategw_acl.py
   test_02_vpc_privategw_static_routes | `Failure` | 5.83 | test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 5.88 | test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 7.87 | test_privategw_acl.py
   ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
   ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 10.43 | test_accounts.py
   test_DeleteDomain | `Error` | 18.60 | test_accounts.py
   test_forceDeleteDomain | `Failure` | 17.42 | test_accounts.py
   test_01_user_remove_VM_running | `Error` | 3.97 | test_accounts.py
   test_delete_account | `Error` | 21.05 | test_network.py
   ContextSuite context=TestPortForwarding>:setup | `Error` | 53.77 | test_network.py
   ContextSuite context=TestPublicIP>:setup | `Error` | 7.42 | test_network.py
   test_reboot_router | `Error` | 5.84 | test_network.py
   test_releaseIP | `Error` | 5.84 | test_network.py
   ContextSuite context=TestRouterRules>:setup | `Error` | 11.63 | test_network.py
   test_01_deployVMInSharedNetwork | `Failure` | 4.18 | test_network.py
   test_02_verifyRouterIpAfterNetworkRestart | `Failure` | 4.11 | test_network.py
   test_03_destroySharedNetwork | `Failure` | 1.05 | test_network.py
   ContextSuite context=TestSharedNetwork>:teardown | `Error` | 2.13 | test_network.py
   test_01_isolated_persistent_network | `Error` | 4.21 | test_persistent_network.py
   ContextSuite context=TestL2PersistentNetworks>:teardown | `Error` | 48.58 | test_persistent_network.py
   test_DeployVmAffinityGroup | `Error` | 5.26 | test_affinity_groups.py
   test_DeployVmAntiAffinityGroup | `Error` | 3.19 | test_affinity_groups.py
   ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
   ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
   ContextSuite context=TestServiceOfferings>:setup | `Error` | 6.86 | test_service_offerings.py
   test_DeployVmAntiAffinityGroup_in_project | `Error` | 5.26 | test_affinity_groups_projects.py
   test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 3.31 | test_routers_network_ops.py
   test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 4.31 | test_routers_network_ops.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Error` | 118.94 | test_routers_network_ops.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Error` | 118.94 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 122.05 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 122.05 | test_routers_network_ops.py
   test_03_RVR_Network_check_router_state | `Error` | 120.24 | test_routers_network_ops.py
   test_03_RVR_Network_check_router_state | `Error` | 120.24 | test_routers_network_ops.py
   ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
   ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
   ContextSuite context=TestAnnotations>:setup | `Error` | 0.00 | test_annotations.py
   test_query_async_job_result | `Error` | 13.93 | test_async_job.py
   test_01_native_to_native_network_migration | `Error` | 16.25 | test_migration.py
   test_02_native_to_native_vpc_migration | `Error` | 6.96 | test_migration.py
   ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py
   ContextSuite context=TestMultipleVolumeAttach>:setup | `Error` | 0.00 | test_attach_multiple_volumes.py
   test_list_vms_metrics | `Error` | 4.18 | test_metrics_api.py
   test_network_acl | `Error` | 5.24 | test_network_acl.py
   test_01_create_delete_portforwarding_fornonvpc | `Error` | 7.01 | test_portforwardingrules.py
   ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py
   test_nic_secondaryip_add_remove | `Error` | 20.97 | test_multipleips_per_nic.py
   test_02_deploy_vm_with_extraconfig_kvm | `Error` | 6.33 | test_deploy_vm_extra_config_data.py
   test_03_update_vm_with_extraconfig_kvm | `Error` | 6.32 | test_deploy_vm_extra_config_data.py
   test_01_add_primary_storage_disabled_host | `Error` | 0.14 | test_primary_storage.py
   test_01_primary_storage_nfs | `Error` | 0.10 | test_primary_storage.py
   ContextSuite context=TestStorageTags>:setup | `Error` | 0.18 | test_primary_storage.py
   test_deploy_vm_from_iso | `Error` | 18.07 | test_deploy_vm_iso.py
   test_00_deploy_vm_root_resize | `Error` | 5.31 | test_deploy_vm_root_resize.py
   test_deployvm_userdata | `Error` | 3.28 | test_deploy_vm_with_userdata.py
   test_deployvm_userdata_post | `Error` | 4.25 | test_deploy_vm_with_userdata.py
   test_deployvm_firstfit | `Error` | 4.28 | test_deploy_vms_with_varied_deploymentplanners.py
   test_deployvm_userconcentrated | `Error` | 4.23 | test_deploy_vms_with_varied_deploymentplanners.py
   test_deployvm_userdispersing | `Error` | 4.24 | test_deploy_vms_with_varied_deploymentplanners.py
   test_03_deploy_vm_domain_service_offering | `Error` | 16.42 | test_domain_service_offerings.py
   test_03_create_vpc_domain_vpc_offering | `Error` | 8.10 | test_domain_vpc_offerings.py
   test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 6.52 | test_kubernetes_clusters.py
   test_02_upgrade_kubernetes_cluster | `Failure` | 7.35 | test_kubernetes_clusters.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 6.31 | test_kubernetes_clusters.py
   test_04_autoscale_kubernetes_cluster | `Failure` | 6.26 | test_kubernetes_clusters.py
   test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 5.25 | test_kubernetes_clusters.py
   test_06_delete_kubernetes_cluster | `Failure` | 6.26 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 6.28 | test_kubernetes_clusters.py
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 6.28 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 7.31 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 115.47 | test_kubernetes_clusters.py
   test_01_events_resource | `Error` | 7.11 | test_events_resource.py
   test_01_events_resource | `Error` | 7.11 | test_events_resource.py
   test_02_deploy_vm_from_direct_download_template | `Error` | 5.29 | test_templates.py
   ContextSuite context=TestTemplates>:setup | `Error` | 31.44 | test_templates.py
   ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py
   test_updating_nics_on_two_shared_networks | `Error` | 4.45 | test_gateway_on_shared_networks.py
   ContextSuite context=TestGatewayOnSharedNetwork>:teardown | `Error` | 6.58 | test_gateway_on_shared_networks.py
   test_01_so_removal_resource_update | `Error` | 4.42 | test_resource_accounting.py
   ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
   ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 5.72 | test_internal_lb.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 8.76 | test_internal_lb.py
   test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 7.66 | test_internal_lb.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 9.80 | test_internal_lb.py
   test_01_verify_ipv6_network | `Error` | 6.89 | test_network_ipv6.py
   test_01_verify_ipv6_network | `Error` | 6.89 | test_network_ipv6.py
   test_09_project_suspend | `Error` | 5.46 | test_projects.py
   test_10_project_activation | `Error` | 6.40 | test_projects.py
   ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
   test_03_network_operations_on_created_vm_of_otheruser | `Error` | 6.42 | test_network_permissions.py
   test_03_network_operations_on_created_vm_of_otheruser | `Error` | 6.42 | test_network_permissions.py
   test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 5.33 | test_network_permissions.py
   ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.34 | test_network_permissions.py
   ContextSuite context=TestDeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
   test_01_secure_vm_migration | `Error` | 70.25 | test_vm_life_cycle.py
   test_02_unsecure_vm_migration | `Error` | 214.65 | test_vm_life_cycle.py
   test_03_secured_to_nonsecured_vm_migration | `Error` | 145.02 | test_vm_life_cycle.py
   test_04_nonsecured_to_secured_vm_migration | `Error` | 143.81 | test_vm_life_cycle.py
   ContextSuite context=TestVMLifeCycle>:setup | `Error` | 5.89 | test_vm_life_cycle.py
   test_01_nic | `Error` | 55.62 | test_nic.py
   ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
   test_02_routervm_iptables_policies | `Error` | 5.29 | test_routers_iptables_default_policy.py
   test_01_single_VPC_iptables_policies | `Error` | 4.26 | test_routers_iptables_default_policy.py
   test_01_deploy_vm_on_specific_host | `Error` | 1.15 | test_vm_deployment_planner.py
   test_02_deploy_vm_on_specific_cluster | `Error` | 3.33 | test_vm_deployment_planner.py
   test_03_deploy_vm_on_specific_pod | `Error` | 3.29 | test_vm_deployment_planner.py
   test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 1.18 | test_vm_deployment_planner.py
   test_05_deploy_vm_on_cluster_override_pod | `Error` | 3.27 | test_vm_deployment_planner.py
   ContextSuite context=TestVmSnapshot>:setup | `Error` | 6.83 | test_vm_snapshots.py
   ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
   ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
   test_01_verify_ipv6_vpc | `Error` | 5.35 | test_vpc_ipv6.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 8.97 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Error` | 9.05 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 8.94 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 10.00 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 7.84 | test_vpc_redundant.py
   test_01_VPC_nics_after_destroy | `Error` | 6.90 | test_vpc_router_nics.py
   test_02_VPC_default_routes | `Error` | 5.85 | test_vpc_router_nics.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 7.42 | test_vpc_vpn.py
   test_01_vpc_site2site_vpn_multiple_options | `Failure` | 6.38 | test_vpc_vpn.py
   test_01_vpc_remote_access_vpn | `Failure` | 4.20 | test_vpc_vpn.py
   test_01_vpc_site2site_vpn | `Failure` | 6.38 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on code in PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#discussion_r939162345


##########
engine/schema/src/main/resources/META-INF/db/schema-41700to41710.sql:
##########
@@ -20,4 +20,111 @@
 --;
 
 UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'network.disable.rpfilter' AND `value` != 'true';
-UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'consoleproxy.disable.rpfilter' AND `value` != 'true';
\ No newline at end of file
+UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'consoleproxy.disable.rpfilter' AND `value` != 'true';
+
+-- Retrieve the hypervisor_type from vm_instance
+DROP VIEW IF EXISTS `cloud`.`domain_router_view`;
+CREATE VIEW `cloud`.`domain_router_view` AS
+    select
+        vm_instance.id id,
+        vm_instance.name name,
+        account.id account_id,
+        account.uuid account_uuid,
+        account.account_name account_name,
+        account.type account_type,
+        domain.id domain_id,
+        domain.uuid domain_uuid,
+        domain.name domain_name,
+        domain.path domain_path,
+        projects.id project_id,
+        projects.uuid project_uuid,
+        projects.name project_name,
+        vm_instance.uuid uuid,
+        vm_instance.created created,
+        vm_instance.state state,
+        vm_instance.removed removed,
+        vm_instance.pod_id pod_id,
+        vm_instance.instance_name instance_name,
+        vm_instance.hypervisor_type,
+        host_pod_ref.uuid pod_uuid,
+        data_center.id data_center_id,
+        data_center.uuid data_center_uuid,
+        data_center.name data_center_name,
+        data_center.networktype data_center_type,
+        data_center.dns1 dns1,
+        data_center.dns2 dns2,
+        data_center.ip6_dns1 ip6_dns1,
+        data_center.ip6_dns2 ip6_dns2,
+        host.id host_id,
+        host.uuid host_uuid,
+        host.name host_name,
+        host.cluster_id cluster_id,
+        vm_template.id template_id,
+        vm_template.uuid template_uuid,
+        service_offering.id service_offering_id,
+        disk_offering.uuid service_offering_uuid,
+        disk_offering.name service_offering_name,

Review Comment:
   Done. Many thanks @shwstppr.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1164301118

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6341 (SL-JID-1823)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1196515381

   @rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1202155561

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] shwstppr closed pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #6341: Enable system VM volume migration for KVM
URL: https://github.com/apache/cloudstack/pull/6341


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] shwstppr commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1203786929

   re-kicking travis


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1164180835

   re-try


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] github-actions[bot] commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1164410623

   This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1161775091

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6341 (SL-JID-1796)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1175439232

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6341 (SL-JID-1907)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1196757476

   <b>Trillian test result (tid-4551)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 11259 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6341-t4551-kvm-centos7.zip
   Smoke tests completed. 36 look OK, 64 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_ISO_usage | `Error` | 1.11 | test_usage.py
   ContextSuite context=TestLBRuleUsage>:setup | `Error` | 9.23 | test_usage.py
   ContextSuite context=TestNatRuleUsage>:setup | `Error` | 15.42 | test_usage.py
   ContextSuite context=TestPublicIPUsage>:setup | `Error` | 21.56 | test_usage.py
   ContextSuite context=TestSnapshotUsage>:setup | `Error` | 28.75 | test_usage.py
   ContextSuite context=TestVmUsage>:setup | `Error` | 49.84 | test_usage.py
   ContextSuite context=TestVolumeUsage>:setup | `Error` | 57.03 | test_usage.py
   ContextSuite context=TestVpnUsage>:setup | `Error` | 65.46 | test_usage.py
   test_delete_account | `Error` | 11.20 | test_network.py
   ContextSuite context=TestPortForwarding>:setup | `Error` | 52.79 | test_network.py
   ContextSuite context=TestPublicIP>:setup | `Error` | 7.81 | test_network.py
   test_reboot_router | `Error` | 5.92 | test_network.py
   test_releaseIP | `Error` | 6.19 | test_network.py
   ContextSuite context=TestRouterRules>:setup | `Error` | 12.11 | test_network.py
   test_01_deployVMInSharedNetwork | `Failure` | 5.26 | test_network.py
   test_02_verifyRouterIpAfterNetworkRestart | `Failure` | 4.13 | test_network.py
   test_03_destroySharedNetwork | `Failure` | 1.05 | test_network.py
   ContextSuite context=TestSharedNetwork>:teardown | `Error` | 2.19 | test_network.py
   test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 4.59 | test_routers_network_ops.py
   test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 4.52 | test_routers_network_ops.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Error` | 119.02 | test_routers_network_ops.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Error` | 119.03 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 119.34 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Error` | 119.34 | test_routers_network_ops.py
   test_03_RVR_Network_check_router_state | `Error` | 116.31 | test_routers_network_ops.py
   test_03_RVR_Network_check_router_state | `Error` | 116.32 | test_routers_network_ops.py
   ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 11.64 | test_accounts.py
   test_DeleteDomain | `Error` | 18.57 | test_accounts.py
   test_forceDeleteDomain | `Failure` | 17.59 | test_accounts.py
   test_01_user_remove_VM_running | `Error` | 5.09 | test_accounts.py
   test_DeployVmAffinityGroup | `Error` | 3.22 | test_affinity_groups.py
   test_DeployVmAntiAffinityGroup | `Error` | 4.23 | test_affinity_groups.py
   ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
   ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
   test_DeployVmAntiAffinityGroup_in_project | `Error` | 4.32 | test_affinity_groups_projects.py
   ContextSuite context=TestAnnotations>:setup | `Error` | 0.00 | test_annotations.py
   ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
   test_query_async_job_result | `Error` | 12.97 | test_async_job.py
   ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py
   ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py
   test_01_native_to_native_network_migration | `Error` | 15.19 | test_migration.py
   test_02_native_to_native_vpc_migration | `Error` | 7.04 | test_migration.py
   ContextSuite context=TestMultipleVolumeAttach>:setup | `Error` | 0.00 | test_attach_multiple_volumes.py
   test_list_vms_metrics | `Error` | 5.32 | test_metrics_api.py
   test_01_create_delete_portforwarding_fornonvpc | `Error` | 6.01 | test_portforwardingrules.py
   test_revoke_certificate | `Error` | 0.01 | test_certauthority_root.py
   ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
   ContextSuite context=TestServiceOfferings>:setup | `Error` | 5.88 | test_service_offerings.py
   test_network_acl | `Error` | 5.23 | test_network_acl.py
   test_01_add_primary_storage_disabled_host | `Error` | 0.15 | test_primary_storage.py
   test_01_primary_storage_nfs | `Error` | 0.10 | test_primary_storage.py
   ContextSuite context=TestStorageTags>:setup | `Error` | 0.18 | test_primary_storage.py
   login_test_saml_user | `Error` | 2.48 | test_login.py
   test_01_positive_tests_usage | `Error` | 8.78 | test_usage_events.py
   ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py
   test_nic_secondaryip_add_remove | `Error` | 10.84 | test_multipleips_per_nic.py
   test_02_deploy_vm_with_extraconfig_kvm | `Error` | 5.43 | test_deploy_vm_extra_config_data.py
   test_03_update_vm_with_extraconfig_kvm | `Error` | 5.51 | test_deploy_vm_extra_config_data.py
   test_01_vpc_privategw_acl | `Failure` | 6.87 | test_privategw_acl.py
   test_02_vpc_privategw_static_routes | `Failure` | 5.80 | test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 5.83 | test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 7.88 | test_privategw_acl.py
   test_deploy_vm_from_iso | `Error` | 18.98 | test_deploy_vm_iso.py
   test_01_vpc_privategw_acl | `Error` | 0.02 | test_privategw_acl_ovs_gre.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 0.02 | test_privategw_acl_ovs_gre.py
   test_05_vpc_privategw_check_interface | `Error` | 0.02 | test_privategw_acl_ovs_gre.py
   test_00_deploy_vm_root_resize | `Error` | 4.29 | test_deploy_vm_root_resize.py
   test_deployvm_userdata | `Error` | 4.31 | test_deploy_vm_with_userdata.py
   test_deployvm_userdata_post | `Error` | 4.32 | test_deploy_vm_with_userdata.py
   test_deployvm_firstfit | `Error` | 4.30 | test_deploy_vms_with_varied_deploymentplanners.py
   test_deployvm_userconcentrated | `Error` | 4.32 | test_deploy_vms_with_varied_deploymentplanners.py
   test_deployvm_userdispersing | `Error` | 4.21 | test_deploy_vms_with_varied_deploymentplanners.py
   test_oobm_issue_power_cycle | `Error` | 3.27 | test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_off | `Error` | 3.23 | test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_on | `Error` | 3.30 | test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_reset | `Error` | 3.32 | test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_soft | `Error` | 2.26 | test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_status | `Error` | 2.21 | test_outofbandmanagement_nestedplugin.py
   test_03_deploy_vm_domain_service_offering | `Error` | 16.42 | test_domain_service_offerings.py
   test_03_create_vpc_domain_vpc_offering | `Error` | 8.27 | test_domain_vpc_offerings.py
   test_role_account_acls_multiple_mgmt_servers | `Error` | 1.89 | test_dynamicroles.py
   test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 7.54 | test_kubernetes_clusters.py
   test_02_upgrade_kubernetes_cluster | `Failure` | 7.44 | test_kubernetes_clusters.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 6.39 | test_kubernetes_clusters.py
   test_04_autoscale_kubernetes_cluster | `Failure` | 7.28 | test_kubernetes_clusters.py
   test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 6.43 | test_kubernetes_clusters.py
   test_06_delete_kubernetes_cluster | `Failure` | 6.28 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 7.36 | test_kubernetes_clusters.py
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 6.28 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 6.31 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 114.72 | test_kubernetes_clusters.py
   test_01_add_delete_kubernetes_supported_version | `Error` | 0.23 | test_kubernetes_supported_versions.py
   test_01_so_removal_resource_update | `Error` | 4.80 | test_resource_accounting.py
   test_01_events_resource | `Error` | 7.16 | test_events_resource.py
   test_01_events_resource | `Error` | 7.16 | test_events_resource.py
   test_01_isolated_persistent_network | `Error` | 3.01 | test_persistent_network.py
   ContextSuite context=TestL2PersistentNetworks>:teardown | `Error` | 42.25 | test_persistent_network.py
   test_updating_nics_on_two_shared_networks | `Error` | 4.46 | test_gateway_on_shared_networks.py
   ContextSuite context=TestGatewayOnSharedNetwork>:teardown | `Error` | 6.61 | test_gateway_on_shared_networks.py
   ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
   test_09_project_suspend | `Error` | 5.43 | test_projects.py
   test_10_project_activation | `Error` | 6.31 | test_projects.py
   ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   test_configure_ha_provider_invalid | `Error` | 0.01 | test_hostha_simulator.py
   test_configure_ha_provider_valid | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_configure_enabledisable_across_clusterzones | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_disable_feature_invalid | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_enable_feature_invalid | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_list_providers | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_multiple_mgmt_server_ownership | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_verify_fsm_available | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_verify_fsm_degraded | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_verify_fsm_fenced | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_verify_fsm_recovering | `Error` | 0.01 | test_hostha_simulator.py
   test_hostha_configure_default_driver | `Error` | 0.01 | test_hostha_simulator.py
   test_hostha_configure_invalid_provider | `Error` | 0.01 | test_hostha_simulator.py
   test_hostha_disable_feature_valid | `Error` | 0.01 | test_hostha_simulator.py
   test_hostha_enable_feature_valid | `Error` | 0.01 | test_hostha_simulator.py
   test_hostha_enable_feature_without_setting_provider | `Error` | 0.01 | test_hostha_simulator.py
   test_list_ha_for_host | `Error` | 0.01 | test_hostha_simulator.py
   test_list_ha_for_host_invalid | `Error` | 0.01 | test_hostha_simulator.py
   test_list_ha_for_host_valid | `Error` | 0.01 | test_hostha_simulator.py
   ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
   test_01_register_template_direct_download_flag | `Error` | 0.15 | test_templates.py
   test_02_deploy_vm_from_direct_download_template | `Error` | 5.33 | test_templates.py
   ContextSuite context=TestTemplates>:setup | `Error` | 29.99 | test_templates.py
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 6.84 | test_internal_lb.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 7.91 | test_internal_lb.py
   test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 7.84 | test_internal_lb.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 9.91 | test_internal_lb.py
   test_01_verify_ipv6_network | `Error` | 5.72 | test_network_ipv6.py
   test_01_verify_ipv6_network | `Error` | 5.73 | test_network_ipv6.py
   ContextSuite context=TestDeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
   test_01_secure_vm_migration | `Error` | 69.54 | test_vm_life_cycle.py
   test_02_unsecure_vm_migration | `Error` | 212.92 | test_vm_life_cycle.py
   test_03_secured_to_nonsecured_vm_migration | `Error` | 146.84 | test_vm_life_cycle.py
   test_04_nonsecured_to_secured_vm_migration | `Error` | 142.05 | test_vm_life_cycle.py
   ContextSuite context=TestVMLifeCycle>:setup | `Error` | 5.95 | test_vm_life_cycle.py
   test_01_nic | `Error` | 55.60 | test_nic.py
   ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
   ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
   test_oobm_background_powerstate_sync | `Failure` | 21.59 | test_outofbandmanagement.py
   test_oobm_background_powerstate_sync | `Error` | 21.59 | test_outofbandmanagement.py
   test_oobm_configure_default_driver | `Error` | 0.05 | test_outofbandmanagement.py
   test_oobm_configure_invalid_driver | `Error` | 0.06 | test_outofbandmanagement.py
   test_oobm_disable_feature_invalid | `Error` | 0.07 | test_outofbandmanagement.py
   test_oobm_disable_feature_valid | `Error` | 1.15 | test_outofbandmanagement.py
   test_oobm_enable_feature_invalid | `Error` | 0.06 | test_outofbandmanagement.py
   test_oobm_enable_feature_valid | `Error` | 1.10 | test_outofbandmanagement.py
   test_oobm_enabledisable_across_clusterzones | `Error` | 11.74 | test_outofbandmanagement.py
   test_oobm_enabledisable_across_clusterzones | `Error` | 11.74 | test_outofbandmanagement.py
   test_oobm_issue_power_cycle | `Error` | 4.27 | test_outofbandmanagement.py
   test_oobm_issue_power_cycle | `Error` | 4.27 | test_outofbandmanagement.py
   test_oobm_issue_power_off | `Error` | 4.27 | test_outofbandmanagement.py
   test_oobm_issue_power_off | `Error` | 4.27 | test_outofbandmanagement.py
   test_oobm_issue_power_on | `Error` | 3.31 | test_outofbandmanagement.py
   test_oobm_issue_power_on | `Error` | 3.31 | test_outofbandmanagement.py
   test_oobm_issue_power_reset | `Error` | 3.33 | test_outofbandmanagement.py
   test_oobm_issue_power_reset | `Error` | 3.33 | test_outofbandmanagement.py
   test_oobm_issue_power_soft | `Error` | 4.27 | test_outofbandmanagement.py
   test_oobm_issue_power_soft | `Error` | 4.27 | test_outofbandmanagement.py
   test_oobm_issue_power_status | `Error` | 4.36 | test_outofbandmanagement.py
   test_oobm_issue_power_status | `Error` | 4.36 | test_outofbandmanagement.py
   test_oobm_multiple_mgmt_server_ownership | `Error` | 1.13 | test_outofbandmanagement.py
   test_oobm_multiple_mgmt_server_ownership | `Error` | 1.13 | test_outofbandmanagement.py
   test_oobm_zchange_password | `Error` | 1.16 | test_outofbandmanagement.py
   test_oobm_zchange_password | `Error` | 1.16 | test_outofbandmanagement.py
   test_01_deploy_vm_on_specific_host | `Error` | 1.15 | test_vm_deployment_planner.py
   test_02_deploy_vm_on_specific_cluster | `Error` | 4.54 | test_vm_deployment_planner.py
   test_03_deploy_vm_on_specific_pod | `Error` | 3.28 | test_vm_deployment_planner.py
   test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 1.17 | test_vm_deployment_planner.py
   test_05_deploy_vm_on_cluster_override_pod | `Error` | 3.31 | test_vm_deployment_planner.py
   test_02_routervm_iptables_policies | `Error` | 5.31 | test_routers_iptables_default_policy.py
   test_01_single_VPC_iptables_policies | `Error` | 4.30 | test_routers_iptables_default_policy.py
   ContextSuite context=TestVmSnapshot>:setup | `Error` | 4.92 | test_vm_snapshots.py
   ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
   ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
   test_01_verify_ipv6_vpc | `Error` | 7.45 | test_vpc_ipv6.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 9.95 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Error` | 7.82 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 10.00 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 7.92 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 7.82 | test_vpc_redundant.py
   test_01_VPC_nics_after_destroy | `Error` | 7.00 | test_vpc_router_nics.py
   test_02_VPC_default_routes | `Error` | 6.88 | test_vpc_router_nics.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 8.56 | test_vpc_vpn.py
   test_01_vpc_site2site_vpn_multiple_options | `Failure` | 7.40 | test_vpc_vpn.py
   test_01_vpc_remote_access_vpn | `Failure` | 4.24 | test_vpc_vpn.py
   test_01_vpc_site2site_vpn | `Failure` | 6.52 | test_vpc_vpn.py
   test_disable_oobm_ha_state_ineligible | `Error` | 0.04 | test_hostha_kvm.py
   test_hostha_configure_default_driver | `Error` | 0.03 | test_hostha_kvm.py
   test_hostha_enable_ha_when_host_disabled | `Error` | 0.03 | test_hostha_kvm.py
   test_hostha_enable_ha_when_host_disconected | `Error` | 0.03 | test_hostha_kvm.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 0.03 | test_hostha_kvm.py
   test_hostha_kvm_host_degraded | `Error` | 0.03 | test_hostha_kvm.py
   test_hostha_kvm_host_fencing | `Error` | 0.03 | test_hostha_kvm.py
   test_hostha_kvm_host_recovering | `Error` | 0.03 | test_hostha_kvm.py
   test_remove_ha_provider_not_possible | `Error` | 0.04 | test_hostha_kvm.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1203050243

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3886


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1203513392

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6341 (SL-JID-2064)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1202089448

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1198981534

   <b>Trillian Build Failed (tid-4562)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] acs-robot commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1203005397

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on code in PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#discussion_r935840434


##########
engine/schema/src/main/resources/META-INF/db/schema-41700to41710.sql:
##########
@@ -20,4 +20,110 @@
 --;
 
 UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'network.disable.rpfilter' AND `value` != 'true';
-UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'consoleproxy.disable.rpfilter' AND `value` != 'true';
\ No newline at end of file
+UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'consoleproxy.disable.rpfilter' AND `value` != 'true';
+
+-- Retrieve the hypervisor_type from vm_instance
+DROP VIEW IF EXISTS `cloud`.`domain_router_view`;
+CREATE VIEW `cloud`.`domain_router_view` AS
+    select
+        vm_instance.id id,
+        vm_instance.name name,
+        account.id account_id,
+        account.uuid account_uuid,
+        account.account_name account_name,
+        account.type account_type,
+        domain.id domain_id,
+        domain.uuid domain_uuid,
+        domain.name domain_name,
+        domain.path domain_path,
+        projects.id project_id,
+        projects.uuid project_uuid,
+        projects.name project_name,
+        vm_instance.uuid uuid,
+        vm_instance.created created,
+        vm_instance.state state,
+        vm_instance.removed removed,
+        vm_instance.pod_id pod_id,
+        vm_instance.instance_name instance_name,
+        vm_instance.hypervisor_type,
+        host_pod_ref.uuid pod_uuid,
+        data_center.id data_center_id,
+        data_center.uuid data_center_uuid,
+        data_center.name data_center_name,
+        data_center.networktype data_center_type,
+        data_center.dns1 dns1,
+        data_center.dns2 dns2,
+        data_center.ip6_dns1 ip6_dns1,
+        data_center.ip6_dns2 ip6_dns2,
+        host.id host_id,
+        host.uuid host_uuid,
+        host.name host_name,
+        host.cluster_id cluster_id,
+        vm_template.id template_id,
+        vm_template.uuid template_uuid,
+        service_offering.id service_offering_id,
+        disk_offering.uuid service_offering_uuid,
+        disk_offering.name service_offering_name,
+        nics.id nic_id,
+        nics.uuid nic_uuid,
+        nics.network_id network_id,
+        nics.ip4_address ip_address,
+        nics.ip6_address ip6_address,
+        nics.ip6_gateway ip6_gateway,
+        nics.ip6_cidr ip6_cidr,
+        nics.default_nic is_default_nic,
+        nics.gateway gateway,
+        nics.netmask netmask,
+        nics.mac_address mac_address,
+        nics.broadcast_uri broadcast_uri,
+        nics.isolation_uri isolation_uri,
+        vpc.id vpc_id,
+        vpc.uuid vpc_uuid,
+        vpc.name vpc_name,
+        networks.uuid network_uuid,
+        networks.name network_name,
+        networks.network_domain network_domain,
+        networks.traffic_type traffic_type,
+        networks.guest_type guest_type,
+        async_job.id job_id,
+        async_job.uuid job_uuid,
+        async_job.job_status job_status,
+        async_job.account_id job_account_id,
+        domain_router.template_version template_version,
+        domain_router.scripts_version scripts_version,
+        domain_router.is_redundant_router is_redundant_router,
+        domain_router.redundant_state redundant_state,
+        domain_router.stop_pending stop_pending,
+        domain_router.role role

Review Comment:
   Thanks, @shwstppr, just committed the fix.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] acs-robot commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1203510171

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1207938904

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1164197288

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6341 (SL-JID-1820)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1164289621

   @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] github-actions[bot] commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1148307302

   This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] acs-robot commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1113847552

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] acs-robot commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1161764718

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1189372489

   @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] acs-robot commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1189372057

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] acs-robot commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1175433196

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] rohityadavcloud commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1196514241

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1203507488

   <b>Trillian test result (tid-4597)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 40100 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6341-t4597-kvm-centos7.zip
   Smoke tests completed. 101 look OK, 0 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1203014908

   @shwstppr a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] shwstppr commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1203014368

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1203056928

   @shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] shwstppr commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1203055888

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] GutoVeronezi commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1117753220

   @rohityadavcloud, done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] shwstppr commented on a diff in pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
shwstppr commented on code in PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#discussion_r935281553


##########
engine/schema/src/main/resources/META-INF/db/schema-41700to41710.sql:
##########
@@ -20,4 +20,110 @@
 --;
 
 UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'network.disable.rpfilter' AND `value` != 'true';
-UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'consoleproxy.disable.rpfilter' AND `value` != 'true';
\ No newline at end of file
+UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'consoleproxy.disable.rpfilter' AND `value` != 'true';
+
+-- Retrieve the hypervisor_type from vm_instance
+DROP VIEW IF EXISTS `cloud`.`domain_router_view`;
+CREATE VIEW `cloud`.`domain_router_view` AS
+    select
+        vm_instance.id id,
+        vm_instance.name name,
+        account.id account_id,
+        account.uuid account_uuid,
+        account.account_name account_name,
+        account.type account_type,
+        domain.id domain_id,
+        domain.uuid domain_uuid,
+        domain.name domain_name,
+        domain.path domain_path,
+        projects.id project_id,
+        projects.uuid project_uuid,
+        projects.name project_name,
+        vm_instance.uuid uuid,
+        vm_instance.created created,
+        vm_instance.state state,
+        vm_instance.removed removed,
+        vm_instance.pod_id pod_id,
+        vm_instance.instance_name instance_name,
+        vm_instance.hypervisor_type,
+        host_pod_ref.uuid pod_uuid,
+        data_center.id data_center_id,
+        data_center.uuid data_center_uuid,
+        data_center.name data_center_name,
+        data_center.networktype data_center_type,
+        data_center.dns1 dns1,
+        data_center.dns2 dns2,
+        data_center.ip6_dns1 ip6_dns1,
+        data_center.ip6_dns2 ip6_dns2,
+        host.id host_id,
+        host.uuid host_uuid,
+        host.name host_name,
+        host.cluster_id cluster_id,
+        vm_template.id template_id,
+        vm_template.uuid template_uuid,
+        service_offering.id service_offering_id,
+        disk_offering.uuid service_offering_uuid,
+        disk_offering.name service_offering_name,
+        nics.id nic_id,
+        nics.uuid nic_uuid,
+        nics.network_id network_id,
+        nics.ip4_address ip_address,
+        nics.ip6_address ip6_address,
+        nics.ip6_gateway ip6_gateway,
+        nics.ip6_cidr ip6_cidr,
+        nics.default_nic is_default_nic,
+        nics.gateway gateway,
+        nics.netmask netmask,
+        nics.mac_address mac_address,
+        nics.broadcast_uri broadcast_uri,
+        nics.isolation_uri isolation_uri,
+        vpc.id vpc_id,
+        vpc.uuid vpc_uuid,
+        vpc.name vpc_name,
+        networks.uuid network_uuid,
+        networks.name network_name,
+        networks.network_domain network_domain,
+        networks.traffic_type traffic_type,
+        networks.guest_type guest_type,
+        async_job.id job_id,
+        async_job.uuid job_uuid,
+        async_job.job_status job_status,
+        async_job.account_id job_account_id,
+        domain_router.template_version template_version,
+        domain_router.scripts_version scripts_version,
+        domain_router.is_redundant_router is_redundant_router,
+        domain_router.redundant_state redundant_state,
+        domain_router.stop_pending stop_pending,
+        domain_router.role role

Review Comment:
   ```suggestion
           domain_router.role role,
           domain_router.software_version software_version
   ```
   
   Added with 4.17.0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1207927277

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3938


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1206836076

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6341)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6341&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6341&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6341&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=CODE_SMELL)
   
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6341&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6341&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6341&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6341&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] acs-robot commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1164287519

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1164340110

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6341)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6341&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6341&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6341&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=CODE_SMELL)
   
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6341&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6341&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6341&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6341&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1161765609

   @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] shwstppr commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1196353464

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1196390431

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3834


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1207698808

   Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 3932


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1203012008

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6341 (SL-JID-2058)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] acs-robot commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1206788610

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] shwstppr commented on a diff in pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
shwstppr commented on code in PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#discussion_r938475428


##########
engine/schema/src/main/resources/META-INF/db/schema-41700to41710.sql:
##########
@@ -20,4 +20,111 @@
 --;
 
 UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'network.disable.rpfilter' AND `value` != 'true';
-UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'consoleproxy.disable.rpfilter' AND `value` != 'true';
\ No newline at end of file
+UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'consoleproxy.disable.rpfilter' AND `value` != 'true';
+
+-- Retrieve the hypervisor_type from vm_instance
+DROP VIEW IF EXISTS `cloud`.`domain_router_view`;
+CREATE VIEW `cloud`.`domain_router_view` AS
+    select
+        vm_instance.id id,
+        vm_instance.name name,
+        account.id account_id,
+        account.uuid account_uuid,
+        account.account_name account_name,
+        account.type account_type,
+        domain.id domain_id,
+        domain.uuid domain_uuid,
+        domain.name domain_name,
+        domain.path domain_path,
+        projects.id project_id,
+        projects.uuid project_uuid,
+        projects.name project_name,
+        vm_instance.uuid uuid,
+        vm_instance.created created,
+        vm_instance.state state,
+        vm_instance.removed removed,
+        vm_instance.pod_id pod_id,
+        vm_instance.instance_name instance_name,
+        vm_instance.hypervisor_type,
+        host_pod_ref.uuid pod_uuid,
+        data_center.id data_center_id,
+        data_center.uuid data_center_uuid,
+        data_center.name data_center_name,
+        data_center.networktype data_center_type,
+        data_center.dns1 dns1,
+        data_center.dns2 dns2,
+        data_center.ip6_dns1 ip6_dns1,
+        data_center.ip6_dns2 ip6_dns2,
+        host.id host_id,
+        host.uuid host_uuid,
+        host.name host_name,
+        host.cluster_id cluster_id,
+        vm_template.id template_id,
+        vm_template.uuid template_uuid,
+        service_offering.id service_offering_id,
+        disk_offering.uuid service_offering_uuid,
+        disk_offering.name service_offering_name,
+        nics.id nic_id,
+        nics.uuid nic_uuid,
+        nics.network_id network_id,
+        nics.ip4_address ip_address,
+        nics.ip6_address ip6_address,
+        nics.ip6_gateway ip6_gateway,
+        nics.ip6_cidr ip6_cidr,
+        nics.default_nic is_default_nic,
+        nics.gateway gateway,
+        nics.netmask netmask,
+        nics.mac_address mac_address,
+        nics.broadcast_uri broadcast_uri,
+        nics.isolation_uri isolation_uri,
+        vpc.id vpc_id,
+        vpc.uuid vpc_uuid,
+        vpc.name vpc_name,
+        networks.uuid network_uuid,
+        networks.name network_name,
+        networks.network_domain network_domain,
+        networks.traffic_type traffic_type,
+        networks.guest_type guest_type,
+        async_job.id job_id,
+        async_job.uuid job_uuid,
+        async_job.job_status job_status,
+        async_job.account_id job_account_id,
+        domain_router.template_version template_version,
+        domain_router.scripts_version scripts_version,
+        domain_router.is_redundant_router is_redundant_router,
+        domain_router.redundant_state redundant_state,
+        domain_router.stop_pending stop_pending,
+        domain_router.role role,
+        domain_router.software_version software_version
+    from
+        `cloud`.`domain_router`
+            inner join
+        `cloud`.`vm_instance` ON vm_instance.id = domain_router.id
+            inner join
+        `cloud`.`account` ON vm_instance.account_id = account.id
+            inner join
+        `cloud`.`domain` ON vm_instance.domain_id = domain.id
+            left join
+        `cloud`.`host_pod_ref` ON vm_instance.pod_id = host_pod_ref.id
+            left join
+        `cloud`.`projects` ON projects.project_account_id = account.id
+            left join
+        `cloud`.`data_center` ON vm_instance.data_center_id = data_center.id
+            left join
+        `cloud`.`host` ON vm_instance.host_id = host.id
+            left join
+        `cloud`.`vm_template` ON vm_instance.vm_template_id = vm_template.id
+            left join
+        `cloud`.`service_offering` ON vm_instance.service_offering_id = service_offering.id
+            left join
+        `cloud`.`disk_offering` ON vm_instance.service_offering_id = disk_offering.id

Review Comment:
   This isn't needed
   ```
           `cloud`.`disk_offering` ON vm_instance.service_offering_id = disk_offering.id
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1203510425

   @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1203557627

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6341)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6341&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6341&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6341&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=CODE_SMELL)
   
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6341&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6341&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6341&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6341&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] shwstppr merged pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
shwstppr merged PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1208629577

   <b>Trillian test result (tid-4645)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38400 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6341-t4645-kvm-centos7.zip
   Smoke tests completed. 101 look OK, 0 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1189377058

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6341 (SL-JID-1983)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] acs-robot commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1113862516

   ## PR Analysis
   https://sonarcloud.io/summary/new_code?id=apachecloudstack&pullRequest=6341
   ## PR Coverage Report
   |**CLASS**|**INSTRUCTION MISSED**|**INSTRUCTION COVERED**|**BRANCH MISSED**|**BRANCH COVERED**|**LINE MISSED**|**LINE COVERED**|
   |-----|-----|-----|-----|-----|-----|-----|
   |Upgrade41700to41710|89|0|4|0|25|0|
   |ApiDBUtils|2350|0|204|0|585|0|
   |ApiResponseHelper|12386|0|1288|0|2833|0|
   |DomainRouterJoinDaoImpl|801|0|80|0|195|0|
   |UserVmManagerImpl|20819|0|2566|0|3871|0|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1164331352

   SonarCloud Quality Gate failed.&nbsp; &nbsp; [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6341)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6341&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6341&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6341&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=CODE_SMELL)
   
   [![10.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '10.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6341&metric=new_coverage&view=list) [10.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6341&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6341&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6341&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1196353775

   @shwstppr a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] acs-robot commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1164181948

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1164287886

   @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1164302623

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6341 (SL-JID-1824)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] shwstppr commented on a diff in pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
shwstppr commented on code in PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#discussion_r938475428


##########
engine/schema/src/main/resources/META-INF/db/schema-41700to41710.sql:
##########
@@ -20,4 +20,111 @@
 --;
 
 UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'network.disable.rpfilter' AND `value` != 'true';
-UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'consoleproxy.disable.rpfilter' AND `value` != 'true';
\ No newline at end of file
+UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'consoleproxy.disable.rpfilter' AND `value` != 'true';
+
+-- Retrieve the hypervisor_type from vm_instance
+DROP VIEW IF EXISTS `cloud`.`domain_router_view`;
+CREATE VIEW `cloud`.`domain_router_view` AS
+    select
+        vm_instance.id id,
+        vm_instance.name name,
+        account.id account_id,
+        account.uuid account_uuid,
+        account.account_name account_name,
+        account.type account_type,
+        domain.id domain_id,
+        domain.uuid domain_uuid,
+        domain.name domain_name,
+        domain.path domain_path,
+        projects.id project_id,
+        projects.uuid project_uuid,
+        projects.name project_name,
+        vm_instance.uuid uuid,
+        vm_instance.created created,
+        vm_instance.state state,
+        vm_instance.removed removed,
+        vm_instance.pod_id pod_id,
+        vm_instance.instance_name instance_name,
+        vm_instance.hypervisor_type,
+        host_pod_ref.uuid pod_uuid,
+        data_center.id data_center_id,
+        data_center.uuid data_center_uuid,
+        data_center.name data_center_name,
+        data_center.networktype data_center_type,
+        data_center.dns1 dns1,
+        data_center.dns2 dns2,
+        data_center.ip6_dns1 ip6_dns1,
+        data_center.ip6_dns2 ip6_dns2,
+        host.id host_id,
+        host.uuid host_uuid,
+        host.name host_name,
+        host.cluster_id cluster_id,
+        vm_template.id template_id,
+        vm_template.uuid template_uuid,
+        service_offering.id service_offering_id,
+        disk_offering.uuid service_offering_uuid,
+        disk_offering.name service_offering_name,
+        nics.id nic_id,
+        nics.uuid nic_uuid,
+        nics.network_id network_id,
+        nics.ip4_address ip_address,
+        nics.ip6_address ip6_address,
+        nics.ip6_gateway ip6_gateway,
+        nics.ip6_cidr ip6_cidr,
+        nics.default_nic is_default_nic,
+        nics.gateway gateway,
+        nics.netmask netmask,
+        nics.mac_address mac_address,
+        nics.broadcast_uri broadcast_uri,
+        nics.isolation_uri isolation_uri,
+        vpc.id vpc_id,
+        vpc.uuid vpc_uuid,
+        vpc.name vpc_name,
+        networks.uuid network_uuid,
+        networks.name network_name,
+        networks.network_domain network_domain,
+        networks.traffic_type traffic_type,
+        networks.guest_type guest_type,
+        async_job.id job_id,
+        async_job.uuid job_uuid,
+        async_job.job_status job_status,
+        async_job.account_id job_account_id,
+        domain_router.template_version template_version,
+        domain_router.scripts_version scripts_version,
+        domain_router.is_redundant_router is_redundant_router,
+        domain_router.redundant_state redundant_state,
+        domain_router.stop_pending stop_pending,
+        domain_router.role role,
+        domain_router.software_version software_version
+    from
+        `cloud`.`domain_router`
+            inner join
+        `cloud`.`vm_instance` ON vm_instance.id = domain_router.id
+            inner join
+        `cloud`.`account` ON vm_instance.account_id = account.id
+            inner join
+        `cloud`.`domain` ON vm_instance.domain_id = domain.id
+            left join
+        `cloud`.`host_pod_ref` ON vm_instance.pod_id = host_pod_ref.id
+            left join
+        `cloud`.`projects` ON projects.project_account_id = account.id
+            left join
+        `cloud`.`data_center` ON vm_instance.data_center_id = data_center.id
+            left join
+        `cloud`.`host` ON vm_instance.host_id = host.id
+            left join
+        `cloud`.`vm_template` ON vm_instance.vm_template_id = vm_template.id
+            left join
+        `cloud`.`service_offering` ON vm_instance.service_offering_id = service_offering.id
+            left join
+        `cloud`.`disk_offering` ON vm_instance.service_offering_id = disk_offering.id

Review Comment:
   This isn't needed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1203054119

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6341)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6341&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6341&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6341&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6341&resolved=false&types=CODE_SMELL)
   
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6341&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6341&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6341&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6341&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1202089705

   @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1202156015

   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland closed pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #6341: Enable system VM volume migration for KVM
URL: https://github.com/apache/cloudstack/pull/6341


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1207670474

   @shwstppr a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1207939648

   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] rohityadavcloud commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1116969761

   Can you merge latest main branch to your PR branch @GutoVeronezi ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] shwstppr commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1164189871

   @GutoVeronezi PR is marked for milestone 4.17.1.0, schema changes are also in 4170to4171 upgrade path but base branch is main. Should it be changed to 4.17 instead? cc @DaanHoogland 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1164182632

   @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1164180195

   awful lot of travis failures


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] acs-robot commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1164289390

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1175433450

   @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] shwstppr commented on a diff in pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
shwstppr commented on code in PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#discussion_r938471490


##########
engine/schema/src/main/resources/META-INF/db/schema-41700to41710.sql:
##########
@@ -20,4 +20,111 @@
 --;
 
 UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'network.disable.rpfilter' AND `value` != 'true';
-UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'consoleproxy.disable.rpfilter' AND `value` != 'true';
\ No newline at end of file
+UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'consoleproxy.disable.rpfilter' AND `value` != 'true';
+
+-- Retrieve the hypervisor_type from vm_instance
+DROP VIEW IF EXISTS `cloud`.`domain_router_view`;
+CREATE VIEW `cloud`.`domain_router_view` AS
+    select
+        vm_instance.id id,
+        vm_instance.name name,
+        account.id account_id,
+        account.uuid account_uuid,
+        account.account_name account_name,
+        account.type account_type,
+        domain.id domain_id,
+        domain.uuid domain_uuid,
+        domain.name domain_name,
+        domain.path domain_path,
+        projects.id project_id,
+        projects.uuid project_uuid,
+        projects.name project_name,
+        vm_instance.uuid uuid,
+        vm_instance.created created,
+        vm_instance.state state,
+        vm_instance.removed removed,
+        vm_instance.pod_id pod_id,
+        vm_instance.instance_name instance_name,
+        vm_instance.hypervisor_type,
+        host_pod_ref.uuid pod_uuid,
+        data_center.id data_center_id,
+        data_center.uuid data_center_uuid,
+        data_center.name data_center_name,
+        data_center.networktype data_center_type,
+        data_center.dns1 dns1,
+        data_center.dns2 dns2,
+        data_center.ip6_dns1 ip6_dns1,
+        data_center.ip6_dns2 ip6_dns2,
+        host.id host_id,
+        host.uuid host_uuid,
+        host.name host_name,
+        host.cluster_id cluster_id,
+        vm_template.id template_id,
+        vm_template.uuid template_uuid,
+        service_offering.id service_offering_id,
+        disk_offering.uuid service_offering_uuid,
+        disk_offering.name service_offering_name,

Review Comment:
   ```suggestion
           service_offering.uuid service_offering_uuid,
           service_offering.name service_offering_name,
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1206788806

   @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1206792479

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6341 (SL-JID-2090)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] shwstppr commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1204978686

   @GutoVeronezi can you please check why tests from `test_vpc_routers` are failing on travis repeatedly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] shwstppr commented on pull request #6341: Enable system VM volume migration for KVM

Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1203053654

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org