You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/09 11:55:18 UTC

[GitHub] [tvm] masahi opened a new pull request #7620: [SPIR-V] Fix pushconstants offset calculation for 32 bit and mixed 32 / 64 bit constants

masahi opened a new pull request #7620:
URL: https://github.com/apache/tvm/pull/7620


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] masahi commented on pull request #7620: [SPIR-V] Fix pushconstants offset calculation for 32 bit values

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #7620:
URL: https://github.com/apache/tvm/pull/7620#issuecomment-794353991


   Replaced dynamic cumsum test with dynamic argsort, since our GPU cumsum seems to have issues with dynamic input in general (doesn't work on rocm either). The dynamic argsort also exercises mixed 64 and 32 bit pushconstants.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] masahi commented on pull request #7620: [SPIR-V] Fix pushconstants offset calculation for 32 bit values

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #7620:
URL: https://github.com/apache/tvm/pull/7620#issuecomment-794903827


   Thanks @tqchen 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] masahi merged pull request #7620: [SPIR-V] Fix pushconstants offset calculation for 32 bit values

Posted by GitBox <gi...@apache.org>.
masahi merged pull request #7620:
URL: https://github.com/apache/tvm/pull/7620


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org