You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by matrosov-nikita <gi...@git.apache.org> on 2017/06/21 11:56:22 UTC
[GitHub] cordova-lib pull request #565: Platform's spec is ignored in config.xml if p...
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-lib/pull/565
Platform's spec is ignored in config.xml if package.json doesn't contain dependency for platform
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
all
### What does this PR do?
Steps to reproduce with cordova@7.0.2-dev:
1) Create app with package.json contains empty dependencies object: `"dependencies": {}`
(e.g. it's default for Visual Studio Cordova template)
2) Add entry into config.xml: `<engine name="windows" spec="https://github.com/apache/cordova-windows.git#4.4.x" />`
3) `cordova platform add windows`
So, if package.json dependencies keys don't include `windows or `cordova-windows`, we should look for a spec in config.xml.
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosov-nikita/cordova-lib fix-platform-installation-from-spec
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/565.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #565
----
commit 2e5e18e52feab3be734d6ffc102f84baaf90ae10
Author: Nikita Matrosov <v-...@microsoft.com>
Date: 2017-06-21T11:27:53Z
Platform's spec is ignored in config.xml if package.json doesn't contain dependency for platform
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #565: Platform's spec is ignored in config.xml if package....
Posted by matrosov-nikita <gi...@git.apache.org>.
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-lib/pull/565
@filmaj, thanks for the information. I'm looking forward to getting back working CI.
Also, I think that I should create a new issue for this bug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #565: CB-12944: Platform's spec is ignored in confi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/565
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #565: CB-12944: Platform's spec is ignored in config.xml i...
Posted by matrosov-nikita <gi...@git.apache.org>.
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-lib/pull/565
@filmaj, done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #565: CB-12944: Platform's spec is ignored in config.xml i...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-lib/pull/565
OK, with the testing all cleaned up in lib now, we can come back to this PR.
@matrosov-nikita let's add a unit test for this please.
Ping @stevengill / @audreyso for review / FYI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #565: Platform's spec is ignored in config.xml if package....
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-lib/pull/565
Yeah, this is a really important change.
One thing to note: all the tests in cordova-lib are failing right now because @stevengill, @audreyso and I are working on changing the tests from being very I/O heavy (integration tests) to lighter unit tests. I should have PR up today to share that will at least get CI back to passing. I will make sure to tag you in that PR, @matrosov-nikita, so you're aware when it drops and can review. The changes will be *big*.
Once we clean master up and get tests passing again here, we should look at incorporating this change (and also ensuring we update the new unit tests to reflect the changes).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #565: Platform's spec is ignored in config.xml if package....
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-lib/pull/565
+1 to creating a new issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org