You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by djoelz <gi...@git.apache.org> on 2015/08/20 16:50:43 UTC
[GitHub] incubator-zeppelin pull request: Configurable Origins and small co...
GitHub user djoelz opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/235
Configurable Origins and small configuration fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/djoelz/incubator-zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/235.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #235
----
commit cecbab8fbb82fde0138d8bff11e16c2b220b0c16
Author: joelz <dj...@gmail.com>
Date: 2015-08-16T10:08:38Z
Fixing cross origin bug for rest calls that allow a malicious user to issue requests from a site other than the zeppelin server.
Adding unit tests and a dependency to mockito to the server project (please comment if that is ok or if there is another preferred mocking framework).
Also upgrading the servelet version from 2.5 to 3.0 as this also fixes a security vulnerability with respect to httonly cookies.
commit df324dea2ff81017c2b9a306b082cdcea5b80ecb
Author: joelz <dj...@gmail.com>
Date: 2015-08-16T10:10:28Z
Fixing cross origin bug for rest calls that allow a malicious user to issue requests from a site other than the zeppelin server.
Adding unit tests and a dependency to mockito to the server project (please comment if that is ok or if there is another preferred mocking framework).
Also upgrading the servelet version from 2.5 to 3.0 as this also fixes a security vulnerability with respect to httonly cookies.
commit a00adc266ef0c1621227055f7e386cf872dac6cf
Author: djoelz <jo...@microsoft.com>
Date: 2015-08-19T17:57:40Z
Merge pull request #1 from apache/master
Merging from Master
commit 47902a6c7d6cfac6d0f5e8932600ae9f6f9bee95
Author: joelz <dj...@gmail.com>
Date: 2015-08-20T14:36:24Z
Fixing cross origin bug for rest calls that allow a malicious user to issue requests from a site other than the zeppelin server.
Adding unit tests and a dependency to mockito to the server project (please comment if that is ok or if there is another preferred mocking framework).
Also upgrading the servelet version from 2.5 to 3.0 as this also fixes a security vulnerability with respect to httonly cookies.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Configurable Origins and small co...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/235#issuecomment-133566060
Thanks @djoelz. I'm merging it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Configurable Origins and small co...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/235
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Configurable Origins and small co...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/235#issuecomment-133230569
Thanks for the fix! Tested and Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Configurable Origins and small co...
Posted by jonbuffington <gi...@git.apache.org>.
Github user jonbuffington commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/235#issuecomment-133364163
@djoelz Thanks for adding the origin names a configuration option. Much appreciated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---