[GitHub] [incubator-heron] nwangtw commented on pull request #3750: Add tagged metric support in MetricsCollector

[GitBox <gi...@apache.org>]

nwangtw commented on pull request #3750:
URL: https://github.com/apache/incubator-heron/pull/3750#issuecomment-1038611609


   Not yet. Got some feedbacks during the meetup and I need to think about it
   more.
   
   On Sun, Feb 13, 2022 at 7:35 PM choi se ***@***.***> wrote:
   
   > @nwangtw <https://github.com/nwangtw> , @joshfischer1108
   > <https://github.com/joshfischer1108>
   >
   > I think it would be good to do prometheus Labels.
   >
   > https://prometheus.io/docs/practices/naming/#labels
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-heron/pull/3750#issuecomment-1038599159>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ABQPBH43YSO6JPCRV7LPXNTU3B2AVANCNFSM5KLYYQXQ>
   > .
   > Triage notifications on the go with GitHub Mobile for iOS
   > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
   > or Android
   > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
   >
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org