You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "abnobdoss (via GitHub)" <gi...@apache.org> on 2026/06/13 00:00:33 UTC
[PR] ci(python): avoid duplicate bindings build [iceberg-rust]
abnobdoss opened a new pull request, #2636:
URL: https://github.com/apache/iceberg-rust/pull/2636
## Which issue does this PR close?
- Closes #.
## What changes are included in this PR?
This updates the Python bindings CI workflow to sync Python dev dependencies directly instead of running `make install`.
The workflow already builds the wheel with `PyO3/maturin-action`, then installs that built wheel with `uv pip install --no-build --reinstall --find-links dist/ pyiceberg-core`.
This looks like an accidental interaction between earlier changes: CI originally ran `uv sync --group dev --no-install-project` directly, then switched to `make install` when that target only performed the same sync. Later, `make install` was updated for local development to also run `maturin develop`, and CI gained an explicit `--no-build` wheel install step.
That meant CI was doing a second full Rust/PyO3 build whose output was immediately replaced by the wheel from the earlier `maturin build` step.
Local development behavior is unchanged: `make install && make test` still installs the editable binding build.
## Are these changes tested?
No new tests are included. This is a CI workflow-only change.
Validation is through the existing Python bindings CI: the `Sync dependencies` step should no longer run `maturin develop`, while the later wheel install and test steps continue to verify the built wheel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ci(python): avoid duplicate bindings build [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu merged PR #2636:
URL: https://github.com/apache/iceberg-rust/pull/2636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org