You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/25 09:47:14 UTC
[GitHub] [airflow] sp1thas opened a new pull request, #23214: `TriggerDagRunOperator`: Fix `DeprecationWarning` on `v2.2-stable`
sp1thas opened a new pull request, #23214:
URL: https://github.com/apache/airflow/pull/23214
Co-authored-by: mingshi <mi...@coinbase.com>
closes: #23124
related: #20781
Base on the discussion we had on #23124 , the purpose of this PR is to cherry-pick [`82e466d`](https://github.com/apache/airflow/commit/82e466d8f9b196e1efba44cc15214b9d0bd3b2d1) in order to disable the `DeprecationWarning` on `v2.2-stable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham closed pull request #23214: `TriggerDagRunOperator`: Fix `DeprecationWarning` on `v2.2-stable`
Posted by GitBox <gi...@apache.org>.
jedcunningham closed pull request #23214: `TriggerDagRunOperator`: Fix `DeprecationWarning` on `v2.2-stable`
URL: https://github.com/apache/airflow/pull/23214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #23214: `TriggerDagRunOperator`: Fix `DeprecationWarning` on `v2.2-stable`
Posted by GitBox <gi...@apache.org>.
eladkal commented on PR #23214:
URL: https://github.com/apache/airflow/pull/23214#issuecomment-1108472322
I don't think we are going to have more releases for 2.2
@jedcunningham ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #23214: `TriggerDagRunOperator`: Fix `DeprecationWarning` on `v2.2-stable`
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #23214:
URL: https://github.com/apache/airflow/pull/23214#issuecomment-1108339997
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #23214: `TriggerDagRunOperator`: Fix `DeprecationWarning` on `v2.2-stable`
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on PR #23214:
URL: https://github.com/apache/airflow/pull/23214#issuecomment-1109171211
Yeah, I'd say it's extremely unlikely we have another 2.2 release at this point. 2.3 is _right_ around the corner now.
Thanks for being proactive and opening this PR though @sp1thas, I appreciate it ๐บ
Even if we did do another 2.2 though, we do a cherry-pick with the `-x` flag to keep a proper history. In most cases, getting a PR in the next milestone is enough - the release manager (or less commonly another committer) would do the cherry-pick manually as part of the release process. So in this case, we'd just need to ask in slack or in the original PR to get #20781 in the next 2.2.x milestone.
Sorry that it was missed and didn't get picked up in a patch release. If you spot this in the future, let us know and we will get it in the next release (most likely).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org