You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Andrzej Bialecki (JIRA)" <ji...@apache.org> on 2008/08/28 15:39:44 UTC
[jira] Created: (HBASE-849) Speed improvement in JenkinsHash
Speed improvement in JenkinsHash
--------------------------------
Key: HBASE-849
URL: https://issues.apache.org/jira/browse/HBASE-849
Project: Hadoop HBase
Issue Type: Improvement
Components: util
Affects Versions: 0.2.1
Reporter: Andrzej Bialecki
Fix For: 0.2.1
The JenkinsHash implementation frequently uses a pattern Long.valueOf( ..expr..). This is costly, because each time the JVM implicitly creates a new Long object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-849) Speed improvement in JenkinsHash
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-849.
-------------------------
Resolution: Fixed
Fix Version/s: 0.18.0
Committed branch and trunk. Thanks for the patch Andrzej.
> Speed improvement in JenkinsHash
> --------------------------------
>
> Key: HBASE-849
> URL: https://issues.apache.org/jira/browse/HBASE-849
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.2.1
> Reporter: Andrzej Bialecki
> Fix For: 0.2.1, 0.18.0
>
> Attachments: jenkins.patch, TestHash.java
>
>
> The JenkinsHash implementation frequently uses a pattern Long.valueOf( ..expr..). This is costly, because each time the JVM implicitly creates a new Long object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-849) Speed improvement in JenkinsHash
Posted by "Andrzej Bialecki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrzej Bialecki updated HBASE-849:
------------------------------------
Attachment: TestHash.java
This simple test calculates the hash a number of times (e.g. 100 mln), both using the patched version and the old version. Additionally, it checks whether output values are equal.
Results show a ~3 times speed improvement:
Speed JenkinsHash:
- 49578 ms
Speed JenkinsHashOld:
- 155266 ms
Regression...
- ok.
> Speed improvement in JenkinsHash
> --------------------------------
>
> Key: HBASE-849
> URL: https://issues.apache.org/jira/browse/HBASE-849
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.2.1
> Reporter: Andrzej Bialecki
> Fix For: 0.2.1
>
> Attachments: jenkins.patch, TestHash.java
>
>
> The JenkinsHash implementation frequently uses a pattern Long.valueOf( ..expr..). This is costly, because each time the JVM implicitly creates a new Long object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-849) Speed improvement in JenkinsHash
Posted by "Andrzej Bialecki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrzej Bialecki updated HBASE-849:
------------------------------------
Attachment: jenkins.patch
This patch replaces the pattern of Long.valueOf with simple (int) casts.
> Speed improvement in JenkinsHash
> --------------------------------
>
> Key: HBASE-849
> URL: https://issues.apache.org/jira/browse/HBASE-849
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.2.1
> Reporter: Andrzej Bialecki
> Fix For: 0.2.1
>
> Attachments: jenkins.patch
>
>
> The JenkinsHash implementation frequently uses a pattern Long.valueOf( ..expr..). This is costly, because each time the JVM implicitly creates a new Long object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.