You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/10/18 09:55:28 UTC
[GitHub] [incubator-dolphinscheduler] IamMujuziMoses opened a new pull request #3942: Process instance mapper
IamMujuziMoses opened a new pull request #3942:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3942
https://github.com/apache/incubator-dolphinscheduler/issues/3938
ProcessInstanceMapper: [CodeClean][DAO]Removed redundant comments #3938
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on a change in pull request #3942: Process instance mapper
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #3942:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3942#discussion_r507125930
##########
File path: sql/create/release-1.0.0_schema/mysql/dolphinscheduler_ddl.sql
##########
@@ -193,8 +193,8 @@ CREATE TABLE `t_escheduler_project` (
`desc` varchar(200) DEFAULT NULL COMMENT 'project description',
`user_id` int(11) DEFAULT NULL COMMENT 'creator id',
`flag` tinyint(4) DEFAULT '1' COMMENT '0 not available, 1 available',
- `create_time` datetime DEFAULT CURRENT_TIMESTAMP COMMENT 'create time',
- `update_time` datetime DEFAULT CURRENT_TIMESTAMP COMMENT 'update time',
Review comment:
Hi, thank you very much for your contribution, but I think "`create_time` datetime DEFAULT CURRENT_TIMESTAMP" is better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3942: Process instance mapper
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #3942:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3942#issuecomment-711145242
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3942&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3942&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3942&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3942&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3942&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3942&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3942&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje
ct/issues?id=apache-dolphinscheduler&pullRequest=3942&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3942&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3942&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3942&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3942&metric=coverage&view=list) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo.png' alt='No Duplication information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3942&metric=duplicated_lines_density&view=list) No Duplication information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on a change in pull request #3942: Process instance mapper
Posted by GitBox <gi...@apache.org>.
dailidong commented on a change in pull request #3942:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3942#discussion_r507159820
##########
File path: sql/create/release-1.0.0_schema/mysql/dolphinscheduler_ddl.sql
##########
@@ -193,8 +193,8 @@ CREATE TABLE `t_escheduler_project` (
`desc` varchar(200) DEFAULT NULL COMMENT 'project description',
`user_id` int(11) DEFAULT NULL COMMENT 'creator id',
`flag` tinyint(4) DEFAULT '1' COMMENT '0 not available, 1 available',
- `create_time` datetime DEFAULT CURRENT_TIMESTAMP COMMENT 'create time',
- `update_time` datetime DEFAULT CURRENT_TIMESTAMP COMMENT 'update time',
Review comment:
Please do not change this file, it belongs to version 1.0.0, it is only used to update to the newer version for those who are still using 1.0.0, and the same reason applies to 1.0.2_schema/mysql/dolphinscheduler_ddl.sql
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on a change in pull request #3942: Process instance mapper
Posted by GitBox <gi...@apache.org>.
dailidong commented on a change in pull request #3942:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3942#discussion_r507159820
##########
File path: sql/create/release-1.0.0_schema/mysql/dolphinscheduler_ddl.sql
##########
@@ -193,8 +193,8 @@ CREATE TABLE `t_escheduler_project` (
`desc` varchar(200) DEFAULT NULL COMMENT 'project description',
`user_id` int(11) DEFAULT NULL COMMENT 'creator id',
`flag` tinyint(4) DEFAULT '1' COMMENT '0 not available, 1 available',
- `create_time` datetime DEFAULT CURRENT_TIMESTAMP COMMENT 'create time',
- `update_time` datetime DEFAULT CURRENT_TIMESTAMP COMMENT 'update time',
Review comment:
don't change this file, it belongs to release 1.0.0 version, just used for update
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] IamMujuziMoses closed pull request #3942: Process instance mapper
Posted by GitBox <gi...@apache.org>.
IamMujuziMoses closed pull request #3942:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3942
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org