You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/03/31 00:09:32 UTC
[GitHub] [helix] xyuanlu opened a new pull request #2004: Add instance disable reason
xyuanlu opened a new pull request #2004:
URL: https://github.com/apache/helix/pull/2004
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
#1992
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
This change adds an API for Disabling instance with optional disabling type and reason.
Added a new api in HelixAdmin
Added 2 optional query param in Rest API PerInstanceAccessor
### Tests
- [X] The following tests are written for this issue:
Expanded these following test class to include the new API
TestZkHelixAdmin.testZkHelixAdmin()
TestPerInstanceAccessor.updateInstance()
New test:
TestInstanceConfig.testSetInstanceEnableWithReason()
- The following is the result of the "mvn test" command on the appropriate module:
```
2022-03-23T01:22:45.9122191Z ##[endgroup]
2022-03-23T01:22:45.9706391Z [info] ./helix-core/target/surefire-reports/TestSuite.txt: Tests run: 1295, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5,466.689 s - in TestSuite
2022-03-23T01:22:45.9709873Z [info] ./zookeeper-api/target/surefire-reports/TestSuite.txt: Tests run: 54, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 107.346 s - in TestSuite
2022-03-23T01:22:45.9714987Z [info] ./metrics-common/target/surefire-reports/TestSuite.txt: Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.365 s - in TestSuite
2022-03-23T01:22:45.9717685Z [info] ./helix-lock/target/surefire-reports/TestSuite.txt: Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 57.3 s - in TestSuite
2022-03-23T01:22:45.9722084Z [info] ./metadata-store-directory-common/target/surefire-reports/TestSuite.txt: Tests run: 31, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.495 s - in TestSuite
2022-03-23T01:22:45.9725027Z [info] ./helix-rest/target/surefire-reports/TestSuite.txt: Tests run: 205, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 141.08 s - in TestSuite
2022-03-23T01:22:45.9727725Z [info] ./recipes/rsync-replicated-file-system/target/surefire-reports/TestSuite.txt: Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.495 s - in TestSuite
2022-03-23T01:22:45.9730328Z [info] ./recipes/rabbitmq-consumer-group/target/surefire-reports/TestSuite.txt: Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.51 s - in TestSuite
2022-03-23T01:22:45.9732681Z [info] ./recipes/distributed-lock-manager/target/surefire-reports/TestSuite.txt: Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.505 s - in TestSuite
2022-03-23T01:22:45.9735031Z [info] ./recipes/service-discovery/target/surefire-reports/TestSuite.txt: Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.48 s - in TestSuite
2022-03-23T01:22:45.9737402Z [info] ./recipes/task-execution/target/surefire-reports/TestSuite.txt: Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.396 s - in TestSuite
2022-03-23T01:22:45.9742030Z [info] ./helix-common/target/surefire-reports/TestSuite.txt: Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.24 s - in TestSuite
```
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue commented on pull request #2004: Add instance disable reason
Posted by GitBox <gi...@apache.org>.
junkaixue commented on pull request #2004:
URL: https://github.com/apache/helix/pull/2004#issuecomment-1084884515
Can you double check the failing @xyuanlu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue merged pull request #2004: Add instance disable reason
Posted by GitBox <gi...@apache.org>.
junkaixue merged pull request #2004:
URL: https://github.com/apache/helix/pull/2004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org