You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "zhangduo (JIRA)" <ji...@apache.org> on 2015/04/22 04:23:58 UTC

[jira] [Commented] (HBASE-13528) A bug on selecting compaction pool

    [ https://issues.apache.org/jira/browse/HBASE-13528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506263#comment-14506263 ] 

zhangduo commented on HBASE-13528:
----------------------------------

I think this line is also redundant?

{code}
long size = selectNow ? compaction.getRequest().getSize() : 0;
{code}

The if selectNow is false, then we will not execute throttleCompaction then 'size' is useless？

Thanks.

> A bug on selecting compaction pool
> ----------------------------------
>
>                 Key: HBASE-13528
>                 URL: https://issues.apache.org/jira/browse/HBASE-13528
>             Project: HBase
>          Issue Type: Bug
>          Components: Compaction
>    Affects Versions: 0.98.12
>            Reporter: Shuaifeng Zhou
>            Assignee: Shuaifeng Zhou
>            Priority: Minor
>             Fix For: 1.0.1, 0.98.13
>
>         Attachments: HBASE-13528-0.98.patch, HBASE-13528-1.0.patch, HBASE-13528-master.patch
>
>
> When the selectNow == true, in requestCompactionInternal, the compaction pool section is incorrect.
> as discussed in:
> http://mail-archives.apache.org/mod_mbox/hbase-dev/201504.mbox/%3CCAAAYAnNC06E-pUG_Fhu9-7x5z--tm_apnFqpuqfn%3DLdNESE3mA%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)