[GitHub] [incubator-eventmesh] zmt-Eason commented on a change in pull request #769: [Issue #768] fix issue in update HTTP subscriber

[GitBox <gi...@apache.org>]

zmt-Eason commented on a change in pull request #769:
URL: https://github.com/apache/incubator-eventmesh/pull/769#discussion_r806378686



##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/SubscriptionItem.java
##########
@@ -66,6 +66,11 @@ public String toString() {
                 + ", type=" + type
                 + '}';
     }
+
+    @Override
+    public SubscriptionItem clone() {

Review comment:
       I suggest implementing Serializable interface to implement deep clone instead of overriding Cloneable interface.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org