You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/10/22 16:31:53 UTC

[GitHub] [ozone] sadanand48 commented on a change in pull request #2751: HDDS-5835. Follow up task to use bucket layout specific DB table in OmMetadataManager.getKeyTable() - part2

sadanand48 commented on a change in pull request #2751:
URL: https://github.com/apache/ozone/pull/2751#discussion_r734685650



##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java
##########
@@ -3666,4 +3668,8 @@ public void testHeadObject() throws IOException {
     }
 
   }
+
+  private BucketLayout getBucketLayout() {

Review comment:
       I think we can add a javadoc for `getBucketLayout()` at least in a few places like OmKeyRequest.java stating that since this is a Non-FSO code path, Bucket.DEFAULT is returned which would correspond to the KeyTable since this method is mostly called from getKeyTable(BucketLayout). 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org