[jira] [Updated] (HBASE-11318) Classes in security subpackages missing @InterfaceAudience annotations.

["Andrew Purtell (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-11318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Purtell updated HBASE-11318:
-----------------------------------

    Fix Version/s:     (was: 1.0.0)
                   2.0.0
         Assignee: Andrew Purtell  (was: Jonathan Hsieh)

I've accepted all of Jon's earlier changes and am making another sweep. Updated patch coming shortly.

> Classes in security subpackages missing @InterfaceAudience annotations.
> -----------------------------------------------------------------------
>
>                 Key: HBASE-11318
>                 URL: https://issues.apache.org/jira/browse/HBASE-11318
>             Project: HBase
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: 0.99.0, 0.96.1.1, 0.98.3
>            Reporter: Jonathan Hsieh
>            Assignee: Andrew Purtell
>             Fix For: 0.99.0, 0.98.5, 2.0.0
>
>         Attachments: hbase-11318.patch
>
>
> I was reading some of the security related code and noticed that many of the security related classes lack @InterfaceAudience markings.
> WIth the current api I believe all but Permission should be Private.  With the introduction of cell level ACL's Permission must be public because it is now exposed in the Mutation setACL calls[1].  
> There is an inconsistency with the Mutation ACL -- the acl setters take Permission instances but the getter returns byte[]'s.  As a follow on issue we could change the signature of Mutation.setACL so we don't have to expose the Permission class and convert it to be byte[], or change the getter to return an exposed Permission instance.
> [1] http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/client/Mutation.html#setACL(java.util.Map)



--
This message was sent by Atlassian JIRA
(v6.2#6252)