You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/07 19:30:51 UTC
[GitHub] [kafka] skaundinya15 opened a new pull request #9143: MINOR: Fix the way total consumed is calculated for verifiable consumer
skaundinya15 opened a new pull request #9143:
URL: https://github.com/apache/kafka/pull/9143
Currently the way we calculate the number of total consumed messages for the verifiable consumer overcounts the number of actually consumed messages. This PR is to fix that to ensure we count the number of consumed messages correctly.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] skaundinya15 commented on pull request #9143: MINOR: Fix the way total consumed is calculated for verifiable consumer
Posted by GitBox <gi...@apache.org>.
skaundinya15 commented on pull request #9143:
URL: https://github.com/apache/kafka/pull/9143#issuecomment-671506739
Link for system test run for this branch: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-08-07--001.1596860596--skaundinya15--minor-fix-total-consumed-for-verifiable-consumer--d799e563e/report.html. The one test that might be related is `streams_broker_compatibility_test` but it looked like it failed on something unrelated, so I am rerunning that test to see if it it's okay.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rajinisivaram merged pull request #9143: MINOR: Fix the way total consumed is calculated for verifiable consumer
Posted by GitBox <gi...@apache.org>.
rajinisivaram merged pull request #9143:
URL: https://github.com/apache/kafka/pull/9143
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] skaundinya15 commented on pull request #9143: MINOR: Fix the way total consumed is calculated for verifiable consumer
Posted by GitBox <gi...@apache.org>.
skaundinya15 commented on pull request #9143:
URL: https://github.com/apache/kafka/pull/9143#issuecomment-671599091
I re-ran the system tests for `streams_broker_compatibility_test` here: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-08-10--001.1597088498--skaundinya15--minor-fix-total-consumed-for-verifiable-consumer--d799e563e/report.html and got a green build. Seems like anything dependent on this method/variable checks out ok for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rajinisivaram commented on pull request #9143: MINOR: Fix the way total consumed is calculated for verifiable consumer
Posted by GitBox <gi...@apache.org>.
rajinisivaram commented on pull request #9143:
URL: https://github.com/apache/kafka/pull/9143#issuecomment-674507951
@skaundinya15 Thanks for running the tests, merging to trunk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org