You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by David Grizzanti <da...@sungard.com> on 2013/03/11 17:06:16 UTC

Review Request: CLOUDSTACK-94: API command, listIsos documentation clarity

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9853/
-----------------------------------------------------------

Review request for cloudstack.


Description
-------

CLOUDSTACK-94: API command, listIsos documentation clarity

Updated API documentation for listIsos command.

Descriptions for id and isofilter descriptions clarified:
- Updated isofilter description with all options and verbiage taken from VirtualMachineTemplate class
- Updated id description 


This addresses bug CLOUDSTACK-94.


Diffs
-----

  api/src/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java 1824612ebb00930c7efbfb88d88f2e94244fe359 

Diff: https://reviews.apache.org/r/9853/diff/


Testing
-------


Thanks,

David Grizzanti

Re: Review Request: CLOUDSTACK-94: API command, listIsos documentation clarity

Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9853/#review17693
-----------------------------------------------------------

Ship it!


Applied to master.  Thanks for the patch!

commit 85e9d63be4d7c275dedd773c63a6aca0cde03356
Author: David Grizzanti <da...@sungard.com>
Date:   Mon Mar 11 12:24:32 2013 -0400

    CLOUDSTACK-94: API command, listIsos documentation clarity
    
    Updated API documentation for listIsos command.
    
    Descriptions for id and isofilter descriptions clarified:
    - Updated isofilter description with all options and verbiage taken from VirtualMachineTemplate class
    - Updated id description
    
    Signed-off-by: Chip Childers <ch...@gmail.com>

- Chip Childers


On March 11, 2013, 4:06 p.m., David Grizzanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9853/
> -----------------------------------------------------------
> 
> (Updated March 11, 2013, 4:06 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-94: API command, listIsos documentation clarity
> 
> Updated API documentation for listIsos command.
> 
> Descriptions for id and isofilter descriptions clarified:
> - Updated isofilter description with all options and verbiage taken from VirtualMachineTemplate class
> - Updated id description 
> 
> 
> This addresses bug CLOUDSTACK-94.
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java 1824612ebb00930c7efbfb88d88f2e94244fe359 
> 
> Diff: https://reviews.apache.org/r/9853/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Grizzanti
> 
>