You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by li...@apache.org on 2017/03/29 07:17:45 UTC
kylin git commit: minor adjust isSpecialTestCube() logic
Repository: kylin
Updated Branches:
refs/heads/KYLIN-2525 fbb8d3e98 -> c322ccf0d
minor adjust isSpecialTestCube() logic
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/c322ccf0
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/c322ccf0
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/c322ccf0
Branch: refs/heads/KYLIN-2525
Commit: c322ccf0db2303c547653da6c40259a19373179b
Parents: fbb8d3e
Author: Li Yang <li...@apache.org>
Authored: Wed Mar 29 15:16:05 2017 +0800
Committer: Li Yang <li...@apache.org>
Committed: Wed Mar 29 15:16:05 2017 +0800
----------------------------------------------------------------------
.../src/main/java/org/apache/kylin/cube/CubeManager.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kylin/blob/c322ccf0/core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
----------------------------------------------------------------------
diff --git a/core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java b/core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
index d1ae41c..0a94fb2 100644
--- a/core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
+++ b/core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
@@ -761,7 +761,7 @@ public class CubeManager implements IRealizationProvider {
CubeDesc cubeDesc = CubeDescManager.getInstance(config).getCubeDesc(cube.getDescName());
checkNotNull(cubeDesc, "cube descriptor '%s' (for cube '%s') not found", cube.getDescName(), cubeName);
- if (!isITTestCube(cubeName))
+ if (!isSpecialTestCube(cubeName))
checkState(cubeDesc.getName().equals(cubeName), "cube name '%s' must be same as descriptor name '%s', but it is not", cubeName, cubeDesc.getName());
if (!cubeDesc.getError().isEmpty()) {
@@ -791,9 +791,9 @@ public class CubeManager implements IRealizationProvider {
}
}
- private boolean isITTestCube(String cubeName) {
- return config.isDevEnv() //
- && (cubeName.startsWith("test_kylin_cube") || cubeName.startsWith("test_streaming") || cubeName.equals("kylin_sales_cube"));
+ private boolean isSpecialTestCube(String cubeName) {
+ return cubeName.equals("kylin_sales_cube") //
+ || config.isDevEnv() && (cubeName.startsWith("test_kylin_cube") || cubeName.startsWith("test_streaming"));
}
private MetadataManager getMetadataManager() {