You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by tcrayford <gi...@git.apache.org> on 2016/07/25 13:36:16 UTC

[GitHub] kafka pull request #1660: KAFKA-3933: always fully read deepIterator

GitHub user tcrayford opened a pull request:

    https://github.com/apache/kafka/pull/1660

    KAFKA-3933: always fully read deepIterator

    Avoids leaking native memory and hence crashing brokers on bootup due to
    running out of memory.
    
    Seeeing as `messageFormat > 0` always reads the full compressed message
    set and is the default going forwards, we can use that behaviour to
    always close the compressor when calling `deepIterator`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/heroku/kafka dont_leak_native_memory_round_2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1660.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1660
    
----
commit 6ec70c1aa63f3d400d286a9893d0fa175f471d09
Author: Tom Crayford <tc...@googlemail.com>
Date:   2016-07-25T13:26:52Z

    KAFKA-3933: always fully read deepIterator
    
    Avoids leaking native memory and hence crashing brokers on bootup due to
    running out of memory.
    
    Seeeing as `messageFormat > 0` always reads the full compressed message
    set and is the default going forwards, we can use that behaviour to
    always close the compressor when calling `deepIterator`

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #1660: KAFKA-3933: always fully read deepIterator

Posted by tcrayford <gi...@git.apache.org>.

Github user tcrayford closed the pull request at:

    https://github.com/apache/kafka/pull/1660


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #1660: KAFKA-3933: always fully read deepIterator

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/1660


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #1660: KAFKA-3933: always fully read deepIterator

Posted by tcrayford <gi...@git.apache.org>.

GitHub user tcrayford reopened a pull request:

    https://github.com/apache/kafka/pull/1660

    KAFKA-3933: always fully read deepIterator

    Avoids leaking native memory and hence crashing brokers on bootup due to
    running out of memory.
    
    Seeeing as `messageFormat > 0` always reads the full compressed message
    set and is the default going forwards, we can use that behaviour to
    always close the compressor when calling `deepIterator`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/heroku/kafka dont_leak_native_memory_round_2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1660.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1660
    
----
commit a1f12a64628365db708c1217cf93e4802f1f03eb
Author: Tom Crayford <tc...@googlemail.com>
Date:   2016-07-25T13:26:52Z

    KAFKA-3933: always fully read deepIterator
    
    Avoids leaking native memory and hence crashing brokers on bootup due to
    running out of memory.
    
    Seeeing as `messageFormat > 0` always reads the full compressed message
    set and is the default going forwards, we can use that behaviour to
    always close the compressor when calling `deepIterator`

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---