[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #847: DISPATCH-1751: Rework how AMQP session incoming-window is derived

[GitBox <gi...@apache.org>]

ChugR commented on a change in pull request #847:
URL: https://github.com/apache/qpid-dispatch/pull/847#discussion_r508519223



##########
File path: src/amqp.c
##########
@@ -96,6 +96,8 @@ const char * const QD_AMQPS_PORT_STR = "5671";
 
 const char * const QD_AMQP_DFLT_PROTO = "tcp";
 
+const int PN_AMQP_MAX_SESSION_CAPACITY_32BIT = 2147483647;

Review comment:
       2^31-1 is not a limit imposed by Proton or by AMQP. It is half of a 32-bit address space and the chances of it being reached are about zero.
   
   I've renamed the constant and reduced its scope in another patch.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org