You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Philip Martin <ph...@codematters.co.uk> on 2005/10/23 22:01:02 UTC

Re: svn commit: r16900 - trunk/subversion/libsvn_wc

dionisos@tigris.org writes:

> Author: dionisos
> Date: Fri Oct 21 16:26:28 2005
> New Revision: 16900

> * subversion/libsvn_wc/log.h
> * subversion/libsvn_wc/log.c
>   (SVN_WC__LOG_ATTR_PROPNAME, SVN_WC__LOG_ATTR_PROPVAL): Move out of the
>   library wide interface too.
>
> * subversion/libsvn_wc/adm_ops.c (remove_revert_file): Fix indenting.

> --- trunk/subversion/libsvn_wc/log.h	(original)
> +++ trunk/subversion/libsvn_wc/log.h	Fri Oct 21 16:26:28 2005
> @@ -57,8 +57,6 @@
>      how these are used. **/
>  #define SVN_WC__LOG_ATTR_NAME           "name"
>  #define SVN_WC__LOG_ATTR_DEST           "dest"
> -#define SVN_WC__LOG_ATTR_PROPNAME       "propname"
> -#define SVN_WC__LOG_ATTR_PROPVAL        "propval"
>  #define SVN_WC__LOG_ATTR_REVISION       "revision"
>  #define SVN_WC__LOG_ATTR_TEXT_REJFILE   "text-rejfile"
>  #define SVN_WC__LOG_ATTR_PROP_REJFILE   "prop-rejfile"
> @@ -149,6 +147,16 @@
>                             const char *path,
>                             apr_pool_t *pool);
>  
> +
> +/* Extend **LOG_ACCUM with 
> + */
> +svn_error_t *
> +svn_wc__loggy_entry_modify (svn_stringbuf_t **log_accum,
> +                            svn_wc_adm_access_t *adm_access,
> +                            const char *name,
> +                            svn_wc_entry_t *entry,
> +                            apr_uint32_t modify_flags,
> +                            apr_pool_t *pool);

That bit is not mentioned in the log message.

-- 
Philip Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r16900 - trunk/subversion/libsvn_wc

Posted by Erik Huelsmann <eh...@gmail.com>.
On 10/24/05, Philip Martin <ph...@codematters.co.uk> wrote:
> dionisos@tigris.org writes:
>
> > Author: dionisos
> > Date: Fri Oct 21 16:26:28 2005
> > New Revision: 16900
>
> > * subversion/libsvn_wc/log.h
> > * subversion/libsvn_wc/log.c
> >   (SVN_WC__LOG_ATTR_PROPNAME, SVN_WC__LOG_ATTR_PROPVAL): Move out of the
> >   library wide interface too.
> >
> > * subversion/libsvn_wc/adm_ops.c (remove_revert_file): Fix indenting.
>
> > --- trunk/subversion/libsvn_wc/log.h  (original)
> > +++ trunk/subversion/libsvn_wc/log.h  Fri Oct 21 16:26:28 2005
> > @@ -57,8 +57,6 @@
> >      how these are used. **/
> >  #define SVN_WC__LOG_ATTR_NAME           "name"
> >  #define SVN_WC__LOG_ATTR_DEST           "dest"
> > -#define SVN_WC__LOG_ATTR_PROPNAME       "propname"
> > -#define SVN_WC__LOG_ATTR_PROPVAL        "propval"
> >  #define SVN_WC__LOG_ATTR_REVISION       "revision"
> >  #define SVN_WC__LOG_ATTR_TEXT_REJFILE   "text-rejfile"
> >  #define SVN_WC__LOG_ATTR_PROP_REJFILE   "prop-rejfile"
> > @@ -149,6 +147,16 @@
> >                             const char *path,
> >                             apr_pool_t *pool);
> >
> > +
> > +/* Extend **LOG_ACCUM with
> > + */
> > +svn_error_t *
> > +svn_wc__loggy_entry_modify (svn_stringbuf_t **log_accum,
> > +                            svn_wc_adm_access_t *adm_access,
> > +                            const char *name,
> > +                            svn_wc_entry_t *entry,
> > +                            apr_uint32_t modify_flags,
> > +                            apr_pool_t *pool);
>
> That bit is not mentioned in the log message.

That's because it shouldn't have been there.

I'll update the log message to indicate in which commit it should have been.

bye,

Erik (who sighs that no commit of his has been painless lately)