You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2009/06/17 15:41:23 UTC
[Bug 6136] New: Add multipass to ReplaceTags plugin
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6136
Summary: Add multipass to ReplaceTags plugin
Product: Spamassassin
Version: 3.2.5
Platform: Other
OS/Version: All
Status: NEW
Severity: enhancement
Priority: P5
Component: Plugins
AssignedTo: dev@spamassassin.apache.org
ReportedBy: jhardin@impsec.org
Created an attachment (id=4463)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4463)
Add multipass to ReplaceTags (no whitespace changes)
ReplaceTags only performs one token substitution pass, which makes it
impossible to have tokens that contain tokens. This can be very useful for
clarity.
Two patches attached, one with whitespace changes included, one without for
clarity.
This is in testing on my production 3.2.5 install.
I'd like to include this in 3.2.6 if possible, as well as 3.3
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6136] [review] Add multipass to ReplaceTags plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6136
--- Comment #5 from John Hardin <jh...@impsec.org> 2009-07-01 20:48:08 PST ---
I've been running the patched trunk (3.3) ReplaceTags.pm on my live and testing
3.2.5 installs without any obvious problems. Apart from the multipass change
here's the diff between 3.2 and 3.3:
--- branches/3.2/lib/Mail/SpamAssassin/Plugin/ReplaceTags.pm 2009-07-01
20:41:35.000000000 -0700
+++ trunk/lib/Mail/SpamAssassin/Plugin/ReplaceTags.pm 2009-07-01
20:42:16.000000000 -0700
@@ -56,6 +56,7 @@
use strict;
use warnings;
use bytes;
+use re 'taint';
use vars qw(@ISA);
@ISA = qw(Mail::SpamAssassin::Plugin);
@@ -179,7 +180,7 @@
sub set_config {
my ($self, $conf) = @_;
- my @cmds = ();
+ my @cmds;
=head1 RULE DEFINITIONS AND PRIVILEGED SETTINGS
...those don't look substantive. Should I just go ahead and copy ReplaceTags.pm
in toto from trunk to 3.2?
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6136] [review] Add multipass to ReplaceTags plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6136
Sidney Markowitz <si...@sidney.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 1 vote |ready to commit
--- Comment #3 from Sidney Markowitz <si...@sidney.com> 2009-06-30 18:21:41 PST ---
+1 for committing the second patch (which appears to be the intention)
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6136] [review] Add multipass to ReplaceTags plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6136
--- Comment #4 from Justin Mason <jm...@jmason.org> 2009-07-01 01:41:29 PST ---
yeah, to clarify, I was referring to whichever one John wants to apply; I
presume that'll probably be the second patch, since I agree that appears to be
the intention.
go ahead John -- you've got the votes ;)
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6136] [review] Add multipass to ReplaceTags plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6136
Justin Mason <jm...@jmason.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Add multipass to |[review] Add multipass to
|ReplaceTags plugin |ReplaceTags plugin
Status Whiteboard| |needs 1 vote
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6136] [review] Add multipass to ReplaceTags plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6136
John Hardin <jh...@impsec.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #8 from John Hardin <jh...@impsec.org> 2009-08-05 19:12:29 PST ---
r790969 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=790969 ) | jhardin | 2009-07-03 10:28:09 -0700 (Fri, 03 Jul 2009) | 2 lines
Backport multipass changes from trunk ReplaceTags.pm to 3.2 branch
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6136] [review] Add multipass to ReplaceTags plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6136
--- Comment #7 from Mark Martinec <Ma...@ijs.si> 2009-07-02 02:51:41 PST ---
> I would stick with patching it, instead of copying in toto; I'm not sure what
> all the side-effects of "use re 'taint'" would be.
I agree. The use re 'taint' is probably harmless, but as it hasn't
been applied to other modules in 3.2, it is probably better
not to do it here. The other one is just cosmetic, removes
redundant assignment, no need to backport it, but you may
if you like it.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6136] Add multipass to ReplaceTags plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6136
--- Comment #2 from Justin Mason <jm...@jmason.org> 2009-06-17 08:17:33 PST ---
+1 for both
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6136] [review] Add multipass to ReplaceTags plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6136
--- Comment #6 from Justin Mason <jm...@jmason.org> 2009-07-02 00:39:10 PST ---
I would stick with patching it, instead of copying in toto; I'm not sure what
all the side-effects of "use re 'taint'" would be.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6136] Add multipass to ReplaceTags plugin
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6136
--- Comment #1 from John Hardin <jh...@impsec.org> 2009-06-17 06:42:15 PST ---
Created an attachment (id=4464)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4464)
Add multipass to ReplaceTags (with whitespace changes to maintain sensible
indentation)
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.