You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Dagmar Timler <da...@gmail.com> on 2013/01/24 15:37:54 UTC
Review Request: Patch for RAVE-874
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9098/
-----------------------------------------------------------
Review request for rave.
Description
-------
Fix the initial SQL query for the DataSourcePopulator, so that will run on operating systems that are case sensitive (e.g. Linux). I also added a warning log message when the initial script is not run because the table is not found. This error should not happen often, so it is worthwhile logging a warning message.
This addresses bug RAVE-874.
https://issues.apache.org/jira/browse/RAVE-874
Diffs
-----
trunk/rave-components/rave-commons/src/main/java/org/apache/rave/jdbc/util/DataSourcePopulator.java 1433856
trunk/rave-portal-resources/src/main/resources_jpa/dataContext.xml 1433856
Diff: https://reviews.apache.org/r/9098/diff/
Testing
-------
Thanks,
Dagmar Timler
Re: Review Request: Patch for RAVE-874
Posted by Raminder Singh <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9098/#review15691
-----------------------------------------------------------
i am still facing mysql error when rave is starting. Added details to JIRA task.
- Raminder Singh
On Jan. 24, 2013, 2:37 p.m., Dagmar Timler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9098/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2013, 2:37 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Fix the initial SQL query for the DataSourcePopulator, so that will run on operating systems that are case sensitive (e.g. Linux). I also added a warning log message when the initial script is not run because the table is not found. This error should not happen often, so it is worthwhile logging a warning message.
>
>
> This addresses bug RAVE-874.
> https://issues.apache.org/jira/browse/RAVE-874
>
>
> Diffs
> -----
>
> trunk/rave-components/rave-commons/src/main/java/org/apache/rave/jdbc/util/DataSourcePopulator.java 1433856
> trunk/rave-portal-resources/src/main/resources_jpa/dataContext.xml 1433856
>
> Diff: https://reviews.apache.org/r/9098/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dagmar Timler
>
>
Re: Review Request: Patch for RAVE-874
Posted by Matt Franklin <mf...@apache.org>.
> On Jan. 28, 2013, 6:44 p.m., Raminder Singh wrote:
> > Ship It!
If this is submitted, can you close it as submitted?
- Matt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9098/#review15754
-----------------------------------------------------------
On Jan. 24, 2013, 2:37 p.m., Dagmar Timler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9098/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2013, 2:37 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Fix the initial SQL query for the DataSourcePopulator, so that will run on operating systems that are case sensitive (e.g. Linux). I also added a warning log message when the initial script is not run because the table is not found. This error should not happen often, so it is worthwhile logging a warning message.
>
>
> This addresses bug RAVE-874.
> https://issues.apache.org/jira/browse/RAVE-874
>
>
> Diffs
> -----
>
> trunk/rave-components/rave-commons/src/main/java/org/apache/rave/jdbc/util/DataSourcePopulator.java 1433856
> trunk/rave-portal-resources/src/main/resources_jpa/dataContext.xml 1433856
>
> Diff: https://reviews.apache.org/r/9098/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dagmar Timler
>
>
Re: Review Request: Patch for RAVE-874
Posted by Raminder Singh <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9098/#review15754
-----------------------------------------------------------
Ship it!
Ship It!
- Raminder Singh
On Jan. 24, 2013, 2:37 p.m., Dagmar Timler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9098/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2013, 2:37 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Fix the initial SQL query for the DataSourcePopulator, so that will run on operating systems that are case sensitive (e.g. Linux). I also added a warning log message when the initial script is not run because the table is not found. This error should not happen often, so it is worthwhile logging a warning message.
>
>
> This addresses bug RAVE-874.
> https://issues.apache.org/jira/browse/RAVE-874
>
>
> Diffs
> -----
>
> trunk/rave-components/rave-commons/src/main/java/org/apache/rave/jdbc/util/DataSourcePopulator.java 1433856
> trunk/rave-portal-resources/src/main/resources_jpa/dataContext.xml 1433856
>
> Diff: https://reviews.apache.org/r/9098/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dagmar Timler
>
>