You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/16 10:10:50 UTC

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1276: Minor fix for uclibcxx test

pkarashchenko commented on code in PR #1276:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1276#discussion_r946583327


##########
testing/uclibcxx_test/Makefile:
##########
@@ -21,7 +21,9 @@
 include $(APPDIR)/Make.defs
 
 CXXEXT := .cpp
-ORIGS  := $(wildcard $(TOPDIR)/libs/libxx/uClibc++/tests/*.cpp)
+
+TESTDIR = $(TOPDIR)/libs/libxx/uClibc++/tests

Review Comment:
   Looks good except the commit message does not reflect the actual change. I think it can be updated to: add TESTDIR variable or something like this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org