You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2011/09/17 15:01:10 UTC
[jira] [Created] (HBASE-4428) Two methods in CacheTestUtils don't
call setDaemon() on the threads
Two methods in CacheTestUtils don't call setDaemon() on the threads
-------------------------------------------------------------------
Key: HBASE-4428
URL: https://issues.apache.org/jira/browse/HBASE-4428
Project: HBase
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
hammerSingleKey() and hammerEviction() don't call t.setDaemon(true) on the threads they create.
The correct pattern is:
{code}
t.setDaemon(true);
ctx.addThread(t);
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4428) Two methods in CacheTestUtils don't
call setDaemon() on the threads
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-4428:
--------------------------
Attachment: test-TestSingleSizeCache.trace
Trace shows the deadlock between doAnAction() and testCacheMultiThreaded().
> Two methods in CacheTestUtils don't call setDaemon() on the threads
> -------------------------------------------------------------------
>
> Key: HBASE-4428
> URL: https://issues.apache.org/jira/browse/HBASE-4428
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 4428.addendum, 4428.txt, test-TestSingleSizeCache.trace
>
>
> hammerSingleKey() and hammerEviction() don't call t.setDaemon(true) on the threads they create.
> The correct pattern is:
> {code}
> t.setDaemon(true);
> ctx.addThread(t);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4428) Two methods in CacheTestUtils don't
call setDaemon() on the threads
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-4428:
--------------------------
Status: Patch Available (was: Open)
> Two methods in CacheTestUtils don't call setDaemon() on the threads
> -------------------------------------------------------------------
>
> Key: HBASE-4428
> URL: https://issues.apache.org/jira/browse/HBASE-4428
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 4428.txt
>
>
> hammerSingleKey() and hammerEviction() don't call t.setDaemon(true) on the threads they create.
> The correct pattern is:
> {code}
> t.setDaemon(true);
> ctx.addThread(t);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4428) Two methods in CacheTestUtils don't
call setDaemon() on the threads
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107146#comment-13107146 ]
Ted Yu commented on HBASE-4428:
-------------------------------
Slab related tests passed in the test suite.
> Two methods in CacheTestUtils don't call setDaemon() on the threads
> -------------------------------------------------------------------
>
> Key: HBASE-4428
> URL: https://issues.apache.org/jira/browse/HBASE-4428
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 4428.txt
>
>
> hammerSingleKey() and hammerEviction() don't call t.setDaemon(true) on the threads they create.
> The correct pattern is:
> {code}
> t.setDaemon(true);
> ctx.addThread(t);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4428) Two methods in CacheTestUtils don't
call setDaemon() on the threads
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-4428:
--------------------------
Attachment: 4428.txt
Running test suite.
> Two methods in CacheTestUtils don't call setDaemon() on the threads
> -------------------------------------------------------------------
>
> Key: HBASE-4428
> URL: https://issues.apache.org/jira/browse/HBASE-4428
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 4428.txt
>
>
> hammerSingleKey() and hammerEviction() don't call t.setDaemon(true) on the threads they create.
> The correct pattern is:
> {code}
> t.setDaemon(true);
> ctx.addThread(t);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4428) Two methods in CacheTestUtils don't
call setDaemon() on the threads
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107218#comment-13107218 ]
Ted Yu commented on HBASE-4428:
-------------------------------
Integrated to TRUNK.
Thanks for the review Stack.
> Two methods in CacheTestUtils don't call setDaemon() on the threads
> -------------------------------------------------------------------
>
> Key: HBASE-4428
> URL: https://issues.apache.org/jira/browse/HBASE-4428
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 4428.txt
>
>
> hammerSingleKey() and hammerEviction() don't call t.setDaemon(true) on the threads they create.
> The correct pattern is:
> {code}
> t.setDaemon(true);
> ctx.addThread(t);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4428) Two methods in CacheTestUtils don't
call setDaemon() on the threads
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107171#comment-13107171 ]
stack commented on HBASE-4428:
------------------------------
+1
> Two methods in CacheTestUtils don't call setDaemon() on the threads
> -------------------------------------------------------------------
>
> Key: HBASE-4428
> URL: https://issues.apache.org/jira/browse/HBASE-4428
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 4428.txt
>
>
> hammerSingleKey() and hammerEviction() don't call t.setDaemon(true) on the threads they create.
> The correct pattern is:
> {code}
> t.setDaemon(true);
> ctx.addThread(t);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4428) Two methods in CacheTestUtils don't
call setDaemon() on the threads
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-4428:
--------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
> Two methods in CacheTestUtils don't call setDaemon() on the threads
> -------------------------------------------------------------------
>
> Key: HBASE-4428
> URL: https://issues.apache.org/jira/browse/HBASE-4428
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 4428.txt
>
>
> hammerSingleKey() and hammerEviction() don't call t.setDaemon(true) on the threads they create.
> The correct pattern is:
> {code}
> t.setDaemon(true);
> ctx.addThread(t);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4428) Two methods in CacheTestUtils don't
call setDaemon() on the threads
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-4428:
--------------------------
Attachment: 4428.addendum
Addendum fixes the deadlock shown in attachment.
ctx.stop() should only be called at the end of testCacheMultiThreaded.
> Two methods in CacheTestUtils don't call setDaemon() on the threads
> -------------------------------------------------------------------
>
> Key: HBASE-4428
> URL: https://issues.apache.org/jira/browse/HBASE-4428
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 4428.addendum, 4428.txt
>
>
> hammerSingleKey() and hammerEviction() don't call t.setDaemon(true) on the threads they create.
> The correct pattern is:
> {code}
> t.setDaemon(true);
> ctx.addThread(t);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4428) Two methods in CacheTestUtils don't
call setDaemon() on the threads
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107277#comment-13107277 ]
Hudson commented on HBASE-4428:
-------------------------------
Integrated in HBase-TRUNK #2227 (See [https://builds.apache.org/job/HBase-TRUNK/2227/])
HBASE-4428 Two methods in CacheTestUtils don't call setDaemon() on the threads
tedyu :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/CacheTestUtils.java
> Two methods in CacheTestUtils don't call setDaemon() on the threads
> -------------------------------------------------------------------
>
> Key: HBASE-4428
> URL: https://issues.apache.org/jira/browse/HBASE-4428
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 4428.txt
>
>
> hammerSingleKey() and hammerEviction() don't call t.setDaemon(true) on the threads they create.
> The correct pattern is:
> {code}
> t.setDaemon(true);
> ctx.addThread(t);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4428) Two methods in CacheTestUtils don't
call setDaemon() on the threads
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107355#comment-13107355 ]
Hudson commented on HBASE-4428:
-------------------------------
Integrated in HBase-TRUNK #2229 (See [https://builds.apache.org/job/HBase-TRUNK/2229/])
HBASE-4428 addendum, call ctx.stop at the end of testCacheMultiThreaded(), not in doAnAction()
tedyu :
Files :
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/MultithreadedTestUtil.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/CacheTestUtils.java
> Two methods in CacheTestUtils don't call setDaemon() on the threads
> -------------------------------------------------------------------
>
> Key: HBASE-4428
> URL: https://issues.apache.org/jira/browse/HBASE-4428
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 4428.addendum, 4428.txt, test-TestSingleSizeCache.trace
>
>
> hammerSingleKey() and hammerEviction() don't call t.setDaemon(true) on the threads they create.
> The correct pattern is:
> {code}
> t.setDaemon(true);
> ctx.addThread(t);
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira