You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/05/04 14:32:28 UTC
[GitHub] [rocketmq] MinXie1209 opened a new issue, #4241: add Message properties valid function
MinXie1209 opened a new issue, #4241:
URL: https://github.com/apache/rocketmq/issues/4241
The issue tracker is used for bug reporting purposes **ONLY** whereas feature request needs to follow the [RIP process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal). To avoid unnecessary duplication, please check whether there is a previous issue before filing a new one.
It is recommended to start a discussion thread in the [mailing lists](http://rocketmq.apache.org/about/contact/) in cases of discussing your deployment plan, API clarification, and other non-bug-reporting issues.
We welcome any friendly suggestions, bug fixes, collaboration, and other improvements.
Please ensure that your bug report is clear and self-contained. Otherwise, it would take additional rounds of communication, thus more time, to understand the problem itself.
Generally, fixing an issue goes through the following steps:
1. Understand the issue reported;
1. Reproduce the unexpected behavior locally;
1. Perform root cause analysis to identify the underlying problem;
1. Create test cases to cover the identified problem;
1. Work out a solution to rectify the behavior and make the newly created test cases pass;
1. Make a pull request and go through peer review;
As a result, it would be very helpful yet challenging if you could provide an isolated project reproducing your reported issue. Anyway, please ensure your issue report is informative enough for the community to pick up. At a minimum, include the following hints:
**BUG REPORT**
1. Please describe the issue you observed:
- What did you do (The steps to reproduce)?
- What is expected to see?
- What did you see instead?
2. Please tell us about your environment:
3. Other information (e.g. detailed explanation, logs, related issues, suggestions on how to fix, etc):
**FEATURE REQUEST**
1. call "MessageDecoder.messageProperties2String(msg.getProperties())"
2. call "org.apache.rocketmq.client.impl.producer.DefaultMQProducerImpl#sendKernelImpl"
The method 1 encryption is called in the method 2 .
When the Message of properties contains a separator, calling the decrypt method cannot return the original data.
So add a conditional judgment when sending a message.
When the properties contains a separator, an exception message is thrown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] MinXie1209 commented on issue #4241: add Message properties valid function
Posted by GitBox <gi...@apache.org>.
MinXie1209 commented on issue #4241:
URL: https://github.com/apache/rocketmq/issues/4241#issuecomment-1118497167
example：
@Test
public void testDecode() {
Map<String, String> properties = new HashMap<>();
String containsSep = MessageDecoder.NAME_VALUE_SEPARATOR + "K1";
properties.put(containsSep, "V1");
String res = MessageDecoder.messageProperties2String(properties);
Map<String, String> decodeProperties = MessageDecoder.string2messageProperties(res);
assertThat(properties.size()).isEqualTo(decodeProperties.size());
}
when properties has MessageDecoder.NAME_VALUE_SEPARATOR or PROPERTY_SEPARATOR ，it cannot restore data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] github-actions[bot] commented on issue #4241: add Message properties valid function
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4241:
URL: https://github.com/apache/rocketmq/issues/4241#issuecomment-1536924557
This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] hzh0425 commented on issue #4241: add Message properties valid function
Posted by GitBox <gi...@apache.org>.
hzh0425 commented on issue #4241:
URL: https://github.com/apache/rocketmq/issues/4241#issuecomment-1118619296
Oh I see what you mean, you can take a look at the MessageDecoderTest#testDecodePropertiesOnIPv6Host test, it doesn't seem to be a problem? Or am I understanding it wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] github-actions[bot] commented on issue #4241: add Message properties valid function
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4241:
URL: https://github.com/apache/rocketmq/issues/4241#issuecomment-1539214351
This issue was closed because it has been inactive for 3 days since being marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] hzh0425 commented on issue #4241: add Message properties valid function
Posted by GitBox <gi...@apache.org>.
hzh0425 commented on issue #4241:
URL: https://github.com/apache/rocketmq/issues/4241#issuecomment-1117496890
hi, can you give a more detailed example to illustrate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] github-actions[bot] closed issue #4241: add Message properties valid function
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #4241: add Message properties valid function
URL: https://github.com/apache/rocketmq/issues/4241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org