You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/10/20 03:34:59 UTC

[GitHub] [cordova] raphinesse commented on issue #165: Cordova not allowing beta versions of plugins to run, instead requiring full version numbers.

raphinesse commented on issue #165: Cordova not allowing beta versions of plugins to run, instead requiring full version numbers.
URL: https://github.com/apache/cordova/issues/165#issuecomment-544217293
 
 
   The error (that is not an `Error` :wink:) originates in [`cordova-ios`](https://github.com/apache/cordova-ios/blob/be68c9f6d49aff85a5f7a52ffcbfd31d5b018a90/bin/templates/scripts/cordova/lib/versions.js#L161-L194). That function should probably be updated to use `semver` to compare the versions. Unless there's a reason to only support a subset of semver.
   
   The same code also seems to be copied to [`cordova-osx`](https://github.com/apache/cordova-osx/blob/7943ec9d3efc3b4d3c5da765988e60cb7f0c7250/bin/lib/versions.js#L107-L140).
   
   I think PRs to fix this issue would be very welcome. If someone creates them, please request a review from me since I'm not watching those platform repos.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org