You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/01/30 01:05:18 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #35360: [SPARK-38065][SQL] Improve the performance of DS V2 aggregate push-down
HyukjinKwon commented on a change in pull request #35360:
URL: https://github.com/apache/spark/pull/35360#discussion_r795111475
##########
File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/SupportsPushDownAggregates.java
##########
@@ -47,6 +47,13 @@
@Evolving
public interface SupportsPushDownAggregates extends ScanBuilder {
+ /**
+ * Whether enable aggregation push-down.
+ *
+ * @return true if enable aggregation push-down, false otherwise.
+ */
+ default boolean enablePushAggregation() { return true; }
Review comment:
Hm, what about just leveraging a configuration for it? Also, users can easily do this via:
```scala
if (!jdbcOptions.pushDownAggregate) return false
```
at `pushAggregation`.
Wonder if it's worth adding another method here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org