You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2019/01/06 19:20:00 UTC

[GitHub] dhlaluku commented on a change in pull request #3113: kvm: Security Group enhancements and refactor old code

dhlaluku commented on a change in pull request #3113: kvm: Security Group enhancements and refactor old code
URL: https://github.com/apache/cloudstack/pull/3113#discussion_r245519076
 
 

 ##########
 File path: scripts/vm/network/security_group.py
 ##########
 @@ -35,11 +33,6 @@
 logpath = "/var/run/cloud/"        # FIXME: Logs should reside in /var/log/cloud
 
 Review comment:
   Since you are refactoring, should we perhaps fix the logpath as well?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services