[GitHub] [doris] yiguolei commented on a diff in pull request #19507: [bugfix](memory) merge block may allocate failed

["yiguolei (via GitHub)" <gi...@apache.org>]

yiguolei commented on code in PR #19507:
URL: https://github.com/apache/doris/pull/19507#discussion_r1189935780


##########
be/src/vec/exec/scan/scanner_scheduler.cpp:
##########
@@ -350,7 +350,10 @@ void ScannerScheduler::_scanner_scan(ScannerScheduler* scheduler, ScannerContext
             ctx->return_free_block(std::move(block));
         } else {
             if (!blocks.empty() && blocks.back()->rows() + block->rows() <= state->batch_size()) {
-                vectorized::MutableBlock(blocks.back().get()).merge(*block);
+                status = vectorized::MutableBlock(blocks.back().get()).merge(*block);
+                if (!status.ok()) {
+                    break;

Review Comment:
   if the status ! = ok, the scanner will set the error status into scanner ctx and set eof=true and cancel the query.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org