You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by medcv <gi...@git.apache.org> on 2018/05/26 22:28:39 UTC
[GitHub] flink pull request #6084: [FLINK-8654][Docs] Extend quickstart docs on how t...
GitHub user medcv opened a pull request:
https://github.com/apache/flink/pull/6084
[FLINK-8654][Docs] Extend quickstart docs on how to submit jobs
## Brief change log
The quickstart documentation explains how to setup the project, build the jar and run things in the IDE, but neither explains how to submit the jar to a cluster nor guides the user to where he could find this information (like the CLI docs).
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/medcv/flink FLINK-8654
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6084.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6084
----
commit 6e8b7434df51e4265a00534de12b6c509d8977fe
Author: Yadan.JS <y_...@...>
Date: 2018-05-26T20:57:59Z
[FLINK-8654][Docs]Extend quickstart docs on how to submit jobs
----
---
[GitHub] flink issue #6084: [FLINK-8654][Docs] Extend quickstart docs on how to submi...
Posted by medcv <gi...@git.apache.org>.
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6084
@zentol sure, will update the PR shortly!
---
[GitHub] flink issue #6084: [FLINK-8654][Docs] Extend quickstart docs on how to submi...
Posted by medcv <gi...@git.apache.org>.
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6084
@zentol yes, that also works. Do you still need me to change it and extend `Next Steps` or we can keep this to provide a bit more info for different ways to submitting jobs.
---
[GitHub] flink issue #6084: [FLINK-8654][Docs] Extend quickstart docs on how to submi...
Posted by medcv <gi...@git.apache.org>.
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6084
@zentol Please review
---
[GitHub] flink issue #6084: [FLINK-8654][Docs] Extend quickstart docs on how to submi...
Posted by medcv <gi...@git.apache.org>.
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6084
@zentol Please review
---
[GitHub] flink pull request #6084: [FLINK-8654][Docs] Extend quickstart docs on how t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/6084
---
[GitHub] flink pull request #6084: [FLINK-8654][Docs] Extend quickstart docs on how t...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6084#discussion_r199761621
--- Diff: docs/quickstart/java_api_quickstart.md ---
@@ -111,7 +111,7 @@ In IntelliJ IDEA recommended way to change JVM options is from the `Help | Edit
## Build Project
If you want to __build/package your project__, go to your project directory and
-run the '`mvn clean package`' command.
--- End diff --
I think it actually looks nicer with the ticks. https://ci.apache.org/projects/flink/flink-docs-master/quickstart/java_api_quickstart.html#build-project
Will revert this while merging.
---
[GitHub] flink issue #6084: [FLINK-8654][Docs] Extend quickstart docs on how to submi...
Posted by medcv <gi...@git.apache.org>.
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6084
@zentol PR has been updated! Please review.
---
[GitHub] flink issue #6084: [FLINK-8654][Docs] Extend quickstart docs on how to submi...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6084
Ideally we only link to other sections, otherwise we end up with redundant (and probably inconsistent) information in the docs. You can link to specific sections for each way to submit jobs, similar to what the existing `Next Steps` section does.
---