You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Chris Riccomini <cr...@apache.org> on 2014/10/27 23:30:45 UTC

Review Request 27251: SAMZA-437

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27251/
-----------------------------------------------------------

Review request for samza.


Bugs: SAMZA-437
    https://issues.apache.org/jira/browse/SAMZA-437


Repository: samza


Description
-------

remove task lifecycle listeners from code and docs


Diffs
-----

  docs/learn/documentation/versioned/container/event-loop.md f0f21b060b9d206cd365bf3d6b6c87ee56867dcc 
  docs/learn/documentation/versioned/jobs/configuration-table.html e3251a639d4f6d734c936ef248c857674c9f2967 
  samza-api/src/main/java/org/apache/samza/task/TaskContext.java 35de8ccf17456b349d8cce4873d4e0f19c5d6010 
  samza-api/src/main/java/org/apache/samza/task/TaskLifecycleListener.java 55524a1bf635ea00ff575daeb0e6d5e227a0a412 
  samza-api/src/main/java/org/apache/samza/task/TaskLifecycleListenerFactory.java 5ed7054567d233f19f4a7e3d5caaf8a15010432e 
  samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala d0c90048fa2b3a153e9dc9565619d117f098525b 
  samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala 66f7dbe6d922acba4674fd81b9fc7baeee55cea3 

Diff: https://reviews.apache.org/r/27251/diff/


Testing
-------


Thanks,

Chris Riccomini

Re: Review Request 27251: SAMZA-437

Posted by Chris Riccomini <cr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27251/
-----------------------------------------------------------

(Updated Nov. 3, 2014, 8:27 p.m.)


Review request for samza.


Bugs: SAMZA-437
    https://issues.apache.org/jira/browse/SAMZA-437


Repository: samza


Description (updated)
-------

add docs to describe wrapped stream task pattern


Merge branch 'master' into SAMZA-437


remove task lifecycle listeners from code and docs


Diffs (updated)
-----

  docs/learn/documentation/versioned/container/event-loop.md f0f21b060b9d206cd365bf3d6b6c87ee56867dcc 
  docs/learn/documentation/versioned/jobs/configuration-table.html e3251a639d4f6d734c936ef248c857674c9f2967 
  samza-api/src/main/java/org/apache/samza/task/TaskContext.java 35de8ccf17456b349d8cce4873d4e0f19c5d6010 
  samza-api/src/main/java/org/apache/samza/task/TaskLifecycleListener.java 55524a1bf635ea00ff575daeb0e6d5e227a0a412 
  samza-api/src/main/java/org/apache/samza/task/TaskLifecycleListenerFactory.java 5ed7054567d233f19f4a7e3d5caaf8a15010432e 
  samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 5885a8862dc64a7342250ec05b2551ad9c73f816 
  samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala 66f7dbe6d922acba4674fd81b9fc7baeee55cea3 

Diff: https://reviews.apache.org/r/27251/diff/


Testing
-------


Thanks,

Chris Riccomini

Re: Review Request 27251: SAMZA-437

Posted by Chinmay Soman <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27251/#review59605
-----------------------------------------------------------

Ship it!


Ship It!

- Chinmay Soman


On Oct. 27, 2014, 10:30 p.m., Chris Riccomini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27251/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2014, 10:30 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-437
>     https://issues.apache.org/jira/browse/SAMZA-437
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> remove task lifecycle listeners from code and docs
> 
> 
> Diffs
> -----
> 
>   docs/learn/documentation/versioned/container/event-loop.md f0f21b060b9d206cd365bf3d6b6c87ee56867dcc 
>   docs/learn/documentation/versioned/jobs/configuration-table.html e3251a639d4f6d734c936ef248c857674c9f2967 
>   samza-api/src/main/java/org/apache/samza/task/TaskContext.java 35de8ccf17456b349d8cce4873d4e0f19c5d6010 
>   samza-api/src/main/java/org/apache/samza/task/TaskLifecycleListener.java 55524a1bf635ea00ff575daeb0e6d5e227a0a412 
>   samza-api/src/main/java/org/apache/samza/task/TaskLifecycleListenerFactory.java 5ed7054567d233f19f4a7e3d5caaf8a15010432e 
>   samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala d0c90048fa2b3a153e9dc9565619d117f098525b 
>   samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala 66f7dbe6d922acba4674fd81b9fc7baeee55cea3 
> 
> Diff: https://reviews.apache.org/r/27251/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chris Riccomini
> 
>