You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kunal642 <gi...@git.apache.org> on 2018/01/09 14:14:34 UTC
[GitHub] carbondata pull request #1781: [CARBONDATA-2012] Add support to load pre-agg...
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1781
[CARBONDATA-2012] Add support to load pre-aggregate in one transaction
Change the pre-aggregate load process to support load as one transaction for the parent and child tables.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [X] Any interfaces changed?
- [X] Any backward compatibility impacted?
- [X] Document update required?
- [X] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kunal642/carbondata transaction_preaggregate
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1781.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1781
----
commit b0827b6e1669827e0e73b32467d7bb190c7601b0
Author: kunal642 <ku...@...>
Date: 2018-01-09T14:06:41Z
add support to load pre-aggregate in one transaction
----
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3218/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2892/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3236/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3262/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3291/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3267/
---
[GitHub] carbondata pull request #1781: [CARBONDATA-2012] Add support to load pre-agg...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1781#discussion_r163768422
--- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ---
@@ -541,9 +543,11 @@ object CarbonDataRDDFactory {
carbonLoadModel,
loadStatus,
newEntryLoadStatus,
- overwriteTable)
+ overwriteTable,
+ uniqueTableStatusId)
+ PreAggregateUtil.commitDataMaps(carbonLoadModel, uniqueTableStatusId)(sqlContext.sparkSession)
--- End diff --
Use try catch and make status fail in case of any issue while committing the datamap
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1781
retest this please
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2111/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2661/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1980/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2043/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2836/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2904/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
LGTM
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1905/
---
[GitHub] carbondata pull request #1781: [CARBONDATA-2012] Add support to load pre-agg...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1781#discussion_r163768054
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala ---
@@ -900,4 +904,75 @@ object PreAggregateUtil {
aggDataMapSchema.getProperties.get("CHILD_SELECT QUERY").replace("&", "=")),
CarbonCommonConstants.DEFAULT_CHARSET)
}
+
+ def commitDataMaps(
+ carbonLoadModel: CarbonLoadModel,
+ uuid: String = "")(sparkSession: SparkSession) {
+ val dataMapSchemas = carbonLoadModel.getCarbonDataLoadSchema.getCarbonTable.getTableInfo
+ .getDataMapSchemaList
+ if (dataMapSchemas.size() >= 1) {
+ val renamedDataMaps = dataMapSchemas.asScala.flatMap {
+ dataMapSchema =>
+ LOGGER.info(
+ s"Renaming table status file for ${ dataMapSchema.getRelationIdentifier.toString }")
+ val carbonTable = CarbonEnv
+ .getCarbonTable(Option(dataMapSchema.getRelationIdentifier.getDatabaseName),
+ dataMapSchema.getRelationIdentifier.getTableName)(sparkSession)
+ val carbonTablePath = new CarbonTablePath(carbonTable.getCarbonTableIdentifier,
+ carbonTable.getTablePath)
+ val oldTableSchemaPath = carbonTablePath.getTableStatusFilePath(uuid)
+ val newTableSchemaPath = carbonTablePath.getTableStatusFilePath()
+ if (renameDataMapTableStatusFiles(oldTableSchemaPath, newTableSchemaPath, uuid)) {
+ Some(carbonTable)
+ } else {
+ None
+ }
+ }
+ if (renamedDataMaps.lengthCompare(dataMapSchemas.size()) < 0) {
+ LOGGER.warn("Reverting table status file to original state")
+ renamedDataMaps.foreach {
+ carbonTable =>
+ val carbonTablePath = new CarbonTablePath(carbonTable.getCarbonTableIdentifier,
+ carbonTable.getTablePath)
+ val backupTableSchemaPath = carbonTablePath.getTableStatusFilePath() + "_backup_" + uuid
+ val tableSchemaPath = carbonTablePath.getTableStatusFilePath()
+ renameDataMapTableStatusFiles(backupTableSchemaPath, tableSchemaPath, "")
+ }
+ sys.error("Failed to update table status for pre-aggregate table")
+ }
+ cleanUpStaleTableStatusFiles(renamedDataMaps, uuid)(sparkSession)
+ }
+ }
+
+ private def renameDataMapTableStatusFiles(oldTableSchemaPath: String,
+ newTableSchemaPath: String, uuid: String) = {
+ val oldCarbonFile = FileFactory.getCarbonFile(oldTableSchemaPath)
+ val newCarbonFile = FileFactory.getCarbonFile(newTableSchemaPath)
+ val backupCreated = if (newCarbonFile.exists()) {
+ newCarbonFile.renameForce(newTableSchemaPath + "_backup_" + uuid)
+ } else {
+ true
+ }
+ if (oldCarbonFile.exists() && backupCreated) {
+ oldCarbonFile.renameForce(newTableSchemaPath)
+ } else {
+ false
+ }
+ }
+
+ def cleanUpStaleTableStatusFiles(carbonTables: Seq[CarbonTable],
+ uuid: String)(sparkSession: SparkSession): Unit = {
+ carbonTables.foreach {
--- End diff --
Delete the created segment folder as well
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1781
retest this please
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1890/
---
[GitHub] carbondata pull request #1781: [CARBONDATA-2012] Add support to load pre-agg...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1781#discussion_r163765811
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala ---
@@ -900,4 +904,75 @@ object PreAggregateUtil {
aggDataMapSchema.getProperties.get("CHILD_SELECT QUERY").replace("&", "=")),
CarbonCommonConstants.DEFAULT_CHARSET)
}
+
+ def commitDataMaps(
+ carbonLoadModel: CarbonLoadModel,
+ uuid: String = "")(sparkSession: SparkSession) {
+ val dataMapSchemas = carbonLoadModel.getCarbonDataLoadSchema.getCarbonTable.getTableInfo
+ .getDataMapSchemaList
+ if (dataMapSchemas.size() >= 1) {
--- End diff --
make as `> 0`
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2065/
---
[GitHub] carbondata pull request #1781: [CARBONDATA-2012] Add support to load pre-agg...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1781#discussion_r163765845
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala ---
@@ -900,4 +904,75 @@ object PreAggregateUtil {
aggDataMapSchema.getProperties.get("CHILD_SELECT QUERY").replace("&", "=")),
CarbonCommonConstants.DEFAULT_CHARSET)
}
+
+ def commitDataMaps(
+ carbonLoadModel: CarbonLoadModel,
+ uuid: String = "")(sparkSession: SparkSession) {
+ val dataMapSchemas = carbonLoadModel.getCarbonDataLoadSchema.getCarbonTable.getTableInfo
+ .getDataMapSchemaList
+ if (dataMapSchemas.size() >= 1) {
+ val renamedDataMaps = dataMapSchemas.asScala.flatMap {
+ dataMapSchema =>
--- End diff --
move to above line
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3279/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1846/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1611/
---
[GitHub] carbondata pull request #1781: [CARBONDATA-2012] Add support to load pre-agg...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1781#discussion_r163763228
--- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java ---
@@ -363,7 +368,7 @@ public static String getEscapeChar(String escapeCharacter) {
public static void readAndUpdateLoadProgressInTableMeta(CarbonLoadModel model,
- boolean insertOverwrite) throws IOException {
+ boolean insertOverwrite, String uuid) throws IOException {
--- End diff --
Better don't change the method, add a new method with UUID and call the same method internally.
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2799/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3123/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2846/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3127/
---
[GitHub] carbondata pull request #1781: [CARBONDATA-2012] Add support to load pre-agg...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1781#discussion_r163765733
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala ---
@@ -900,4 +904,75 @@ object PreAggregateUtil {
aggDataMapSchema.getProperties.get("CHILD_SELECT QUERY").replace("&", "=")),
CarbonCommonConstants.DEFAULT_CHARSET)
}
+
+ def commitDataMaps(
+ carbonLoadModel: CarbonLoadModel,
+ uuid: String = "")(sparkSession: SparkSession) {
+ val dataMapSchemas = carbonLoadModel.getCarbonDataLoadSchema.getCarbonTable.getTableInfo
+ .getDataMapSchemaList
--- End diff --
enter to new line
```
carbonLoadModel.getCarbonDataLoadSchema.getCarbonTable.getTableInfo.getDataMapSchemaList
```
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3245/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3066/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1781
Can you add more description, why the current loading flow is not transactional?
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3077/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2803/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2031/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3399/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1427/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2802/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2922/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2057/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2897/
---
[GitHub] carbondata pull request #1781: [CARBONDATA-2012] Add support to load pre-agg...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1781#discussion_r163763834
--- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ---
@@ -541,9 +543,11 @@ object CarbonDataRDDFactory {
carbonLoadModel,
loadStatus,
newEntryLoadStatus,
- overwriteTable)
+ overwriteTable,
+ uniqueTableStatusId)
+ PreAggregateUtil.commitDataMaps(carbonLoadModel, uniqueTableStatusId)(sqlContext.sparkSession)
--- End diff --
Add a listener for postStatusUpdateEvent and commit in that listner
---
[GitHub] carbondata pull request #1781: [CARBONDATA-2012] Add support to load pre-agg...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1781#discussion_r163765433
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala ---
@@ -587,7 +590,8 @@ object PreAggregateUtil {
segmentToLoad: String,
validateSegments: Boolean,
isOverwrite: Boolean,
- sparkSession: SparkSession): Unit = {
+ sparkSession: SparkSession,
+ uuid: String): Unit = {
--- End diff --
take this as Option and default as None
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2027/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3201/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2159/
---
[GitHub] carbondata pull request #1781: [CARBONDATA-2012] Add support to load pre-agg...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1781#discussion_r163768617
--- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java ---
@@ -148,7 +148,7 @@ public static void deleteStorePath(String path) {
* @throws IOException
*/
public static boolean recordNewLoadMetadata(LoadMetadataDetails newMetaEntry,
- CarbonLoadModel loadModel, boolean loadStartEntry, boolean insertOverwrite)
+ CarbonLoadModel loadModel, boolean loadStartEntry, boolean insertOverwrite, String uuid)
--- End diff --
Add a new method
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3215/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3347/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3222/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1601/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3314/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1456/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2689/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3202/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
retest this please
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1887/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1985/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2077/
---
[GitHub] carbondata pull request #1781: [CARBONDATA-2012] Add support to load pre-agg...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1781#discussion_r163765303
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala ---
@@ -240,11 +247,12 @@ case class CarbonLoadDataCommand(
table.getCarbonTableIdentifier,
carbonLoadModel)
OperationListenerBus.getInstance.fireEvent(loadTablePostExecutionEvent, operationContext)
+
} catch {
case CausedBy(ex: NoRetryException) =>
// update the load entry in table status file for changing the status to marked for delete
if (isUpdateTableStatusRequired) {
- CarbonLoaderUtil.updateTableStatusForFailure(carbonLoadModel)
+ CarbonLoaderUtil.updateTableStatusForFailure(carbonLoadModel, uuid)
--- End diff --
Add a new method, don't change the current method signature
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3226/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
@kunal642 Still there is a chance of non synchronized commit with child tables. Better create a uniqueid while loading main table and pass that id to all child table loading. And all child tables tablestatus should be created with that uniqueid. And commit all tablestatus through renaming at once in main table commit.
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
retest this please
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3272/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2012/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2815/
---
[GitHub] carbondata pull request #1781: [CARBONDATA-2012] Add support to load pre-agg...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1781#discussion_r163763954
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
@@ -75,6 +75,8 @@ class CarbonSession(@transient val sc: SparkContext,
object CarbonSession {
+ private var isInitialized = false
--- End diff --
What it is used for?
---
[GitHub] carbondata pull request #1781: [CARBONDATA-2012] Add support to load pre-agg...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1781#discussion_r163765562
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala ---
@@ -900,4 +904,75 @@ object PreAggregateUtil {
aggDataMapSchema.getProperties.get("CHILD_SELECT QUERY").replace("&", "=")),
CarbonCommonConstants.DEFAULT_CHARSET)
}
+
+ def commitDataMaps(
--- End diff --
Add comment step by step of flow.
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1564/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1781
retest this please
---
[GitHub] carbondata pull request #1781: [CARBONDATA-2012] Add support to load pre-agg...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1781
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3119/
---
[GitHub] carbondata pull request #1781: [CARBONDATA-2012] Add support to load pre-agg...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1781#discussion_r163767814
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala ---
@@ -900,4 +904,75 @@ object PreAggregateUtil {
aggDataMapSchema.getProperties.get("CHILD_SELECT QUERY").replace("&", "=")),
CarbonCommonConstants.DEFAULT_CHARSET)
}
+
+ def commitDataMaps(
+ carbonLoadModel: CarbonLoadModel,
+ uuid: String = "")(sparkSession: SparkSession) {
+ val dataMapSchemas = carbonLoadModel.getCarbonDataLoadSchema.getCarbonTable.getTableInfo
+ .getDataMapSchemaList
+ if (dataMapSchemas.size() >= 1) {
+ val renamedDataMaps = dataMapSchemas.asScala.flatMap {
+ dataMapSchema =>
+ LOGGER.info(
+ s"Renaming table status file for ${ dataMapSchema.getRelationIdentifier.toString }")
+ val carbonTable = CarbonEnv
+ .getCarbonTable(Option(dataMapSchema.getRelationIdentifier.getDatabaseName),
+ dataMapSchema.getRelationIdentifier.getTableName)(sparkSession)
+ val carbonTablePath = new CarbonTablePath(carbonTable.getCarbonTableIdentifier,
+ carbonTable.getTablePath)
+ val oldTableSchemaPath = carbonTablePath.getTableStatusFilePath(uuid)
+ val newTableSchemaPath = carbonTablePath.getTableStatusFilePath()
+ if (renameDataMapTableStatusFiles(oldTableSchemaPath, newTableSchemaPath, uuid)) {
+ Some(carbonTable)
+ } else {
+ None
+ }
+ }
+ if (renamedDataMaps.lengthCompare(dataMapSchemas.size()) < 0) {
+ LOGGER.warn("Reverting table status file to original state")
+ renamedDataMaps.foreach {
+ carbonTable =>
+ val carbonTablePath = new CarbonTablePath(carbonTable.getCarbonTableIdentifier,
+ carbonTable.getTablePath)
+ val backupTableSchemaPath = carbonTablePath.getTableStatusFilePath() + "_backup_" + uuid
+ val tableSchemaPath = carbonTablePath.getTableStatusFilePath()
+ renameDataMapTableStatusFiles(backupTableSchemaPath, tableSchemaPath, "")
+ }
+ sys.error("Failed to update table status for pre-aggregate table")
+ }
+ cleanUpStaleTableStatusFiles(renamedDataMaps, uuid)(sparkSession)
+ }
+ }
+
+ private def renameDataMapTableStatusFiles(oldTableSchemaPath: String,
+ newTableSchemaPath: String, uuid: String) = {
+ val oldCarbonFile = FileFactory.getCarbonFile(oldTableSchemaPath)
+ val newCarbonFile = FileFactory.getCarbonFile(newTableSchemaPath)
+ val backupCreated = if (newCarbonFile.exists()) {
+ newCarbonFile.renameForce(newTableSchemaPath + "_backup_" + uuid)
+ } else {
+ true
+ }
+ if (oldCarbonFile.exists() && backupCreated) {
+ oldCarbonFile.renameForce(newTableSchemaPath)
+ } else {
+ false
+ }
+ }
+
--- End diff --
Better add the code as below
```
private def renameDataMapTableStatusFiles(oldTableSchemaPath: String,
newTableSchemaPath: String, uuid: String) = {
val oldCarbonFile = FileFactory.getCarbonFile(oldTableSchemaPath)
val newCarbonFile = FileFactory.getCarbonFile(newTableSchemaPath)
if (newCarbonFile.exists() && oldCarbonFile.exists()) {
if (newCarbonFile.renameForce(newTableSchemaPath + "_backup_" + uuid)) {
oldCarbonFile.renameForce(newTableSchemaPath)
} else {
false
}
} else {
false
}
}
```
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1894/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3105/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3219/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
retest this please
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2895/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3302/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2894/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3111/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1580/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3246/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1567/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3098/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3101/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3176/
---
[GitHub] carbondata pull request #1781: [CARBONDATA-2012] Add support to load pre-agg...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1781#discussion_r163762604
--- Diff: core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java ---
@@ -252,6 +252,10 @@ public String getTableStatusFilePath() {
return getMetaDataDir() + File.separator + TABLE_STATUS_FILE;
}
+ public String getTableStatusFilePath(String uuid) {
--- End diff --
change name to `getTableStatusFilePathWithUUID`
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2037/
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2011/
---
[GitHub] carbondata pull request #1781: [CARBONDATA-2012] Add support to load pre-agg...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1781#discussion_r163765606
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala ---
@@ -900,4 +904,75 @@ object PreAggregateUtil {
aggDataMapSchema.getProperties.get("CHILD_SELECT QUERY").replace("&", "=")),
CarbonCommonConstants.DEFAULT_CHARSET)
}
+
+ def commitDataMaps(
+ carbonLoadModel: CarbonLoadModel,
+ uuid: String = "")(sparkSession: SparkSession) {
--- End diff --
take this a Option and default to None
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1781
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3200/
---
[GitHub] carbondata pull request #1781: [CARBONDATA-2012] Add support to load pre-agg...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1781#discussion_r163768485
--- Diff: integration/spark2/src/main/spark2.2/CarbonSessionState.scala ---
@@ -208,6 +207,8 @@ class CarbonSessionStateBuilder(sparkSession: SparkSession,
parentState: Option[SessionState] = None)
extends HiveSessionStateBuilder(sparkSession, parentState) {
+ CarbonSession.initListeners()
--- End diff --
remove it
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1781
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3138/
---
[GitHub] carbondata pull request #1781: [CARBONDATA-2012] Add support to load pre-agg...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1781#discussion_r163763929
--- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ---
@@ -541,9 +543,11 @@ object CarbonDataRDDFactory {
carbonLoadModel,
loadStatus,
newEntryLoadStatus,
- overwriteTable)
+ overwriteTable,
+ uniqueTableStatusId)
+ PreAggregateUtil.commitDataMaps(carbonLoadModel, uniqueTableStatusId)(sqlContext.sparkSession)
if (!done) {
- CarbonLoaderUtil.updateTableStatusForFailure(carbonLoadModel)
+ CarbonLoaderUtil.updateTableStatusForFailure(carbonLoadModel, uniqueTableStatusId)
--- End diff --
Add a abort event to abort all child datamaps status files
---
[GitHub] carbondata issue #1781: [CARBONDATA-2012] Add support to load pre-aggregate ...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1781
retest this please
---