[GitHub] kaxil commented on a change in pull request #3894: [AIRFLOW-3055] add get_dataset and get_datasets_list to bigquery_hook

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #3894: [AIRFLOW-3055] add get_dataset and get_datasets_list to bigquery_hook
URL: https://github.com/apache/incubator-airflow/pull/3894#discussion_r219524410
 
 

 ##########
 File path: airflow/contrib/hooks/bigquery_hook.py
 ##########
 @@ -1375,6 +1375,75 @@ def delete_dataset(self, project_id, dataset_id):
                 'BigQuery job failed. Error was: {}'.format(err.content)
             )
 
+    def get_dataset(self, dataset_id="", project_id=""):
+        """
+        Method returned dataset_resource if dataset exist
+        and raised 404 error if dataset does not exist
+
+        :param dataset_id: dataset_id to get
+        :type dataset_id: project_id there to find dataset
+        :param project_id:
+        :type  project_id:
 
 Review comment:
   Docstrings seem to be incomplete

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services