You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/07 13:04:47 UTC

[GitHub] [incubator-nuttx] patacongo commented on issue #220: ELF64 support

patacongo commented on issue #220: ELF64 support
URL: https://github.com/apache/incubator-nuttx/pull/220#issuecomment-583380800
 
 
   "Please note that some typedefs such as Elf32_xxx, Elf64_xxx, Elf_xxx still violate NuttX conding standard."  Those are the names used in other elf header files.  I have missed feelings if they should be made to match the coding standard or not.  They are controlled by any standard, so the answer is that they should be made to follow the NuttX coding standard someday.
   
   Given that Masayuki has suggested waiting for subsequent PRs to address the comments, is this PR ready to be merged now?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services