You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/26 13:33:20 UTC

[GitHub] [spark] William1104 opened a new pull request #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name

William1104 opened a new pull request #24221: [SPARK-27248][SQL] refresh table should recreate cache with same cache name
URL: https://github.com/apache/spark/pull/24221
 
 
   ## What changes were proposed in this pull request?
   
   If we refresh a cached table, the table cache will be first uncached and then recache (lazily). Currently, the logic is embedded in CatalogImpl.refreshTable method.
   The current implementation does not preserve the cache name and storage level. As a result, cache name and cache level could be changed after a REFERSH. IMHO, it is not what a user would expect.
   I would like to fix this behavior by first save the cache name and storage level for recaching the table.
   
   ## How was this patch tested?
   
   Two unit tests are added to make sure cache name is unchanged upon table refresh. Before applying this patch, the test created for qualified case would fail.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org