[jira] [Commented] (ZOOKEEPER-1440) Spurious log error messages when QuorumCnxManager is shutting down

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13932427#comment-13932427 ] 

Hadoop QA commented on ZOOKEEPER-1440:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12527472/patch.txt
  against trunk revision 1576174.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1952//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1952//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1952//console

This message is automatically generated.

> Spurious log error messages when QuorumCnxManager is shutting down
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1440
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1440
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: quorum, server
>    Affects Versions: 3.4.3
>            Reporter: Jordan Zimmerman
>            Assignee: Jordan Zimmerman
>            Priority: Minor
>             Fix For: 3.5.0
>
>         Attachments: patch.txt, patch.txt
>
>
> When shutting down the QuroumPeer, ZK server logs unnecessary errors. See QuorumCnxManager.Listener.run() - ss.accept() will throw an exception when it is closed. The catch (IOException e) will log errors. It should first check the shutdown field to see if the Listener is being shutdown. If it is, the exception is correct and no errors should be logged.



--
This message was sent by Atlassian JIRA
(v6.2#6252)