[GitHub] [james-project] Arsnael commented on a diff in pull request #1491: [FIX] Subscribe/unsubscribe mailbox should be per user based

["Arsnael (via GitHub)" <gi...@apache.org>]

Arsnael commented on code in PR #1491:
URL: https://github.com/apache/james-project/pull/1491#discussion_r1140042330


##########
server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/MailboxChangesMethodContract.scala:
##########
@@ -1023,6 +1023,70 @@ trait MailboxChangesMethodContract {
       }
     }
 
+    @Test
+    def mailboxChangesShouldReturnUpdatedChangesWhenSubscribedOnlyPerUser(server: GuiceJamesServer): Unit = {

Review Comment:
   I've been hesitating a lot on how to test it... Is it the right test and how can we be sure there is no change for the other sharee actually? Thread.sleep() given a certain time then check Andre is still unsubscribed? Doesn't really feel precise...
   
   Should we have similar tests in Mailbox/Set?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org