You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/09/13 13:49:06 UTC
[GitHub] [spark] itholic opened a new pull request, #42909: [WIP][SPARK-45153][BUILD][PS] Rebalance testing time for `pyspark-pandas-connect-part1`
itholic opened a new pull request, #42909:
URL: https://github.com/apache/spark/pull/42909
### What changes were proposed in this pull request?
This PR proposes to rebalance the tests for `pyspark-pandas-connect-part1`.
### Why are the changes needed?
We rebalance the CI by splitting slow tests into multiple parts, but `pyspark-pandas-connect-part1` takes almost an hour than other splitted `pyspark-pandas-connect-partx` tests as below:
|pyspark-pandas-connect-part0|pyspark-pandas-connect-part1|pyspark-pandas-connect-part2|
|--|--|--|
|1h 51m|2h 55m|1h 54m|
### Does this PR introduce _any_ user-facing change?
No, this PR is proposed to improve the build infra.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
We should manually check the CI from GitHub Actions after PR is opened.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42909: [WIP][SPARK-45153][BUILD][PS] Rebalance testing time for `pyspark-pandas-connect-part1`
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42909:
URL: https://github.com/apache/spark/pull/42909#issuecomment-1717888920
Thank you for keeping improving this, @itholic .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42909: [SPARK-45153][BUILD][PS] Rebalance testing time for `pyspark-pandas-connect-part1`
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42909:
URL: https://github.com/apache/spark/pull/42909#issuecomment-1724207858
Merged to master for Apache Spark 4.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #42909: [SPARK-45153][BUILD][PS] Rebalance testing time for `pyspark-pandas-connect-part1`
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #42909:
URL: https://github.com/apache/spark/pull/42909#issuecomment-1723020252
Result summary:
|pyspark-pandas-connect-part0|pyspark-pandas-connect-part1|pyspark-pandas-connect-part2|pyspark-pandas-connect-part3|
|--|--|--|--|
|1h 55m|1h 56m|1h 50m|1h 32m|
Now each tests run within 2 hrs. I think it seems to be better balanced than before.
cc @HyukjinKwon @dongjoon-hyun WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #42909: [SPARK-45153][BUILD][PS] Rebalance testing time for `pyspark-pandas-connect-part1`
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #42909: [SPARK-45153][BUILD][PS] Rebalance testing time for `pyspark-pandas-connect-part1`
URL: https://github.com/apache/spark/pull/42909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org