You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/17 15:49:03 UTC

[GitHub] [airflow] norm commented on a diff in pull request #25758: Used many-to-many relation for finding attached dataset events.

norm commented on code in PR #25758:
URL: https://github.com/apache/airflow/pull/25758#discussion_r948134956


##########
airflow/api_connexion/endpoints/dag_run_endpoint.py:
##########
@@ -116,43 +115,12 @@ def get_upstream_dataset_events(
             "DAGRun not found",
             detail=f"DAGRun with DAG ID: '{dag_id}' and DagRun ID: '{dag_run_id}' not found",
         )
-    events = _get_upstream_dataset_events(dag_run=dag_run, session=session)
+    events = dag_run.dataset_events

Review Comment:
   Without prior knowledge the name does imply events *from* the DagRun, not *causing* the DagRun, at least to my eyes. `consumed_dataset_events` perhaps?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org