You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/20 10:52:13 UTC

[GitHub] [shardingsphere] linghengqian commented on pull request #21048: Update snakeyaml to 1.32 to fix yaml deserialization problem

linghengqian commented on PR #21048:
URL: https://github.com/apache/shardingsphere/pull/21048#issuecomment-1252178995

   > @linghengqian apologies but I only discovered this a few hours ago - snakeyaml 1.32 has a change that makes 3Mb the default limit on the size of yaml file it will parse. To parse bigger files, you need to update a LoaderOptions instance and use that when creating a snakeyaml ParserImpl.
   > 
   > https://bitbucket.org/snakeyaml/snakeyaml/src/26624702fab8e0a1c301d7fad723c048528f75c3/src/main/java/org/yaml/snakeyaml/LoaderOptions.java#lines-146
   > 
   > https://bitbucket.org/snakeyaml/snakeyaml/wiki/Changes 
   
   - I can hardly imagine a situation in which ShardingSphere would export or import a yaml `> 3MB`, since there has never been such a unit test before.  I noticed that Spring Boot often uses very long YAML files, but the corresponding commit does not reflect this, refer to https://github.com/spring-projects/spring-boot/commit/59448ce5d2d622dfc53813c0389e017142443388 .  It would be nice if a friend found a failing unit test in an new open issue.😂


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org