You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/24 11:46:06 UTC
[GitHub] [incubator-nuttx-apps] saramonteiro opened a new pull request #628: examples/oneshot: fixed wrong constant and refactored
saramonteiro opened a new pull request #628:
URL: https://github.com/apache/incubator-nuttx-apps/pull/628
## Summary
This little PR is intended only to:
* Fix a wrong constant that was being used to convert time unities and
* Refactor the code using constant definitions instead of raw numbers.
## Impact
N/A
## Testing
After the changes the maximum delay became correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] v01d commented on pull request #628: examples/oneshot: fixed wrong constant and refactored
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #628:
URL: https://github.com/apache/incubator-nuttx-apps/pull/628#issuecomment-805831735
> LGTM All except but the name of NSEC_PER_USEC seams backwards, doesn't it?
>
> Number for Seconds per micros Second should be NUSEC_PER_SEC, Number for micros Seconds per Second but that looks like anther PR....
It refers to nanoseconds per microsecond.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on pull request #628: examples/oneshot: fixed wrong constant and refactored
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #628:
URL: https://github.com/apache/incubator-nuttx-apps/pull/628#issuecomment-805917741
>
>
> > LGTM All except but the name of NSEC_PER_USEC seams backwards, doesn't it?
> > Number for Seconds per micros Second should be NUSEC_PER_SEC, Number for micros Seconds per Second but that looks like anther PR....
>
> It refers to nanoseconds per microsecond.
You are interpreting the name incorrectly. NSEC_PER_USEC does not stand for number seconds per microsecond, it stands for the number nanoseconds per microsecond. NSEC always refers to nanonseconds in clock.h.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] saramonteiro commented on pull request #628: examples/oneshot: fixed wrong constant and refactored
Posted by GitBox <gi...@apache.org>.
saramonteiro commented on pull request #628:
URL: https://github.com/apache/incubator-nuttx-apps/pull/628#issuecomment-805912501
> LGTM All except but the name of NSEC_PER_USEC seams backwards, doesn't it?
>
> Number for Seconds per micros Second should be NUSEC_PER_SEC, Number for micros Seconds per Second but that looks like anther PR....
Hey David,
these definitions are not mine. They're from `include/nuttx/clock.h` and I don't think it's a good idea to change it.
It will break several files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] davids5 merged pull request #628: examples/oneshot: fixed wrong constant and refactored
Posted by GitBox <gi...@apache.org>.
davids5 merged pull request #628:
URL: https://github.com/apache/incubator-nuttx-apps/pull/628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org