You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2023/01/05 16:18:01 UTC

[GitHub] [solr] risdenk opened a new pull request, #1278: SOLR-15787: Fix Windows

risdenk opened a new pull request, #1278:
URL: https://github.com/apache/solr/pull/1278

   https://issues.apache.org/jira/browse/SOLR-15787


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] risdenk closed pull request #1278: SOLR-15787: Fix Windows

Posted by GitBox <gi...@apache.org>.
risdenk closed pull request #1278: SOLR-15787: Fix Windows
URL: https://github.com/apache/solr/pull/1278


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] risdenk commented on pull request #1278: SOLR-15787: Fix Windows

Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1278:
URL: https://github.com/apache/solr/pull/1278#issuecomment-1372723904

   Sigh well there are assumptions all over ConfigSetService that use `/` so maybe https://github.com/apache/solr/pull/1239 is the right way to go. I have no idea if we normalize to `/` if Windows will work with this outside of tests. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] dsmiley commented on pull request #1278: SOLR-15787: Fix Windows

Posted by GitBox <gi...@apache.org>.
dsmiley commented on PR #1278:
URL: https://github.com/apache/solr/pull/1278#issuecomment-1372883940

   Nonetheless I liked some of the minor code improvements in this PR so I think we should bring them in.  Feel free to push them to Nazerke's PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org