You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/07 21:24:13 UTC

[GitHub] [arrow] jonkeane commented on a change in pull request #11875: ARROW-14839: [R] test-fedora-r-clang-sanitizer job failing due to snappy causing a sanitizer error

jonkeane commented on a change in pull request #11875:
URL: https://github.com/apache/arrow/pull/11875#discussion_r764372413



##########
File path: ci/scripts/r_docker_configure.sh
##########
@@ -77,5 +77,19 @@ if [ "$ARROW_S3" == "ON" ] || [ "$ARROW_R_DEV" == "TRUE" ]; then
   fi
 fi
 
+# Install patch if it doesn't already exist
+if [ ! $(command -v patch) ]; then
+  if [ "`which dnf`" ]; then
+    dnf install -y patch
+  elif [ "`which yum`" ]; then
+    yum install -y patch
+  elif [ "`which zypper`" ]; then
+    zypper install -y patch
+  else
+    apt-get update
+    apt-get install -y patch
+  fi
+fi

Review comment:
       This is not strictly necessary (see below where we disable snappy if we can't find `patch`), but it makes sure that we do have `patch` available so we do exercise this code in the sanitizer in our CI




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org