You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Salikh Zakirov <Sa...@Intel.com> on 2006/11/03 17:46:53 UTC
[drlvm][icl] Fix for the gc_gen compilation problem with Intel Compiler,
windows
Hi,
the following trivial patch fixes the gc_gen compilation problem
with Intel Compiler under Windows:
--- vm/gc_gen/src/common/gc_platform.h
+++ vm/gc_gen/src/common/gc_platform.h
@@ -29,7 +29,7 @@ #include <open/hythread_ext.h>
#define USEC_PER_SEC INT64_C(1000000)
-#define VmThreadHandle (void*)
+#define VmThreadHandle void*
#define VmEventHandle hysem_t
#define THREAD_OK TM_ERROR_NONE
I did not file the JIRA since the fix is trivial and would be obvious fix to anyone
trying compile gc_gen with Intel Compiler on Windows.
Could anyone commit this fix?
Re: [drlvm][icl] Fix for the gc_gen compilation problem with Intel Compiler, windows
Posted by Xiao-Feng Li <xi...@gmail.com>.
I'd suggest to commit this patch since I have to admit that to define
a type as parenthesis may not be a good code style.
Thanks,
xiaofeng
On 11/5/06, Geir Magnusson Jr. <ge...@pobox.com> wrote:
> How about fixing the intel compiler? :)
>
> I suppose there's no harm, and if so, we'll find out...
>
> Alexei Fedotov wrote:
> > +1
> > for committing
> >
> > A declaration VmThreadHandle h; is converts to (void*) h;
> > Intel compiler doesn't understand type names in brackets.
> >
> > This is a fix for http://issues.apache.org/jira/browse/HARMONY-1897
> > icl build on Windows failed
> >
> > Thanks, Salikh. A good catch!
> >
> > On 11/3/06, Salikh Zakirov <Sa...@intel.com> wrote:
> >> Hi,
> >>
> >> the following trivial patch fixes the gc_gen compilation problem
> >> with Intel Compiler under Windows:
> >>
> >> --- vm/gc_gen/src/common/gc_platform.h
> >> +++ vm/gc_gen/src/common/gc_platform.h
> >> @@ -29,7 +29,7 @@ #include <open/hythread_ext.h>
> >>
> >> #define USEC_PER_SEC INT64_C(1000000)
> >>
> >> -#define VmThreadHandle (void*)
> >> +#define VmThreadHandle void*
> >> #define VmEventHandle hysem_t
> >> #define THREAD_OK TM_ERROR_NONE
> >>
> >>
> >> I did not file the JIRA since the fix is trivial and would be obvious
> >> fix to anyone
> >> trying compile gc_gen with Intel Compiler on Windows.
> >>
> >> Could anyone commit this fix?
> >>
> >>
> >
>
Re: [drlvm][icl] Fix for the gc_gen compilation problem with Intel
Compiler, windows
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
How about fixing the intel compiler? :)
I suppose there's no harm, and if so, we'll find out...
Alexei Fedotov wrote:
> +1
> for committing
>
> A declaration VmThreadHandle h; is converts to (void*) h;
> Intel compiler doesn't understand type names in brackets.
>
> This is a fix for http://issues.apache.org/jira/browse/HARMONY-1897
> icl build on Windows failed
>
> Thanks, Salikh. A good catch!
>
> On 11/3/06, Salikh Zakirov <Sa...@intel.com> wrote:
>> Hi,
>>
>> the following trivial patch fixes the gc_gen compilation problem
>> with Intel Compiler under Windows:
>>
>> --- vm/gc_gen/src/common/gc_platform.h
>> +++ vm/gc_gen/src/common/gc_platform.h
>> @@ -29,7 +29,7 @@ #include <open/hythread_ext.h>
>>
>> #define USEC_PER_SEC INT64_C(1000000)
>>
>> -#define VmThreadHandle (void*)
>> +#define VmThreadHandle void*
>> #define VmEventHandle hysem_t
>> #define THREAD_OK TM_ERROR_NONE
>>
>>
>> I did not file the JIRA since the fix is trivial and would be obvious
>> fix to anyone
>> trying compile gc_gen with Intel Compiler on Windows.
>>
>> Could anyone commit this fix?
>>
>>
>
Re: [drlvm][icl] Fix for the gc_gen compilation problem with Intel
Compiler, windows
Posted by Salikh Zakirov <Sa...@Intel.com>.
Alexey Petrenko wrote:
> Salikh could you please attach your patch to the HARMONY-1897
> specified by Alexei?
done
Re: [drlvm][icl] Fix for the gc_gen compilation problem with Intel Compiler, windows
Posted by Alexey Petrenko <al...@gmail.com>.
IMHO having corresponding JIRA is always good :)
Salikh could you please attach your patch to the HARMONY-1897
specified by Alexei?
SY, Alexey
2006/11/4, Alexei Fedotov <al...@gmail.com>:
> +1
> for committing
>
> A declaration VmThreadHandle h; is converts to (void*) h;
> Intel compiler doesn't understand type names in brackets.
>
> This is a fix for http://issues.apache.org/jira/browse/HARMONY-1897
> icl build on Windows failed
>
> Thanks, Salikh. A good catch!
>
> On 11/3/06, Salikh Zakirov <Sa...@intel.com> wrote:
> > Hi,
> >
> > the following trivial patch fixes the gc_gen compilation problem
> > with Intel Compiler under Windows:
> >
> > --- vm/gc_gen/src/common/gc_platform.h
> > +++ vm/gc_gen/src/common/gc_platform.h
> > @@ -29,7 +29,7 @@ #include <open/hythread_ext.h>
> >
> > #define USEC_PER_SEC INT64_C(1000000)
> >
> > -#define VmThreadHandle (void*)
> > +#define VmThreadHandle void*
> > #define VmEventHandle hysem_t
> > #define THREAD_OK TM_ERROR_NONE
> >
> >
> > I did not file the JIRA since the fix is trivial and would be obvious fix to anyone
> > trying compile gc_gen with Intel Compiler on Windows.
> >
> > Could anyone commit this fix?
> >
> >
>
Re: [drlvm][icl] Fix for the gc_gen compilation problem with Intel Compiler, windows
Posted by Alexei Fedotov <al...@gmail.com>.
+1
for committing
A declaration VmThreadHandle h; is converts to (void*) h;
Intel compiler doesn't understand type names in brackets.
This is a fix for http://issues.apache.org/jira/browse/HARMONY-1897
icl build on Windows failed
Thanks, Salikh. A good catch!
On 11/3/06, Salikh Zakirov <Sa...@intel.com> wrote:
> Hi,
>
> the following trivial patch fixes the gc_gen compilation problem
> with Intel Compiler under Windows:
>
> --- vm/gc_gen/src/common/gc_platform.h
> +++ vm/gc_gen/src/common/gc_platform.h
> @@ -29,7 +29,7 @@ #include <open/hythread_ext.h>
>
> #define USEC_PER_SEC INT64_C(1000000)
>
> -#define VmThreadHandle (void*)
> +#define VmThreadHandle void*
> #define VmEventHandle hysem_t
> #define THREAD_OK TM_ERROR_NONE
>
>
> I did not file the JIRA since the fix is trivial and would be obvious fix to anyone
> trying compile gc_gen with Intel Compiler on Windows.
>
> Could anyone commit this fix?
>
>