You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2017/06/27 18:24:57 UTC
Review Request 60478: HIVE-16761 LLAP IO: SMB joins fail elevator
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60478/
-----------------------------------------------------------
Review request for hive and Deepak Jaiswal.
Repository: hive-git
Description
-------
see jira
Diffs
-----
itests/src/test/resources/testconfiguration.properties 0aadee3e3d
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java c22d446320
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d4e14a88c2
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatchCtx.java e546a658c7
ql/src/test/queries/clientpositive/llap_smb.q PRE-CREATION
ql/src/test/results/clientpositive/llap/llap_smb.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/60478/diff/1/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 60478: HIVE-16761 LLAP IO: SMB joins fail elevator
Posted by Sergey Shelukhin <se...@hortonworks.com>.
See the above comment. Will uncomment when I can run the test with correct result to verify :)
From: Deepak Jaiswal <no...@reviews.apache.org>> on behalf of Deepak Jaiswal <dj...@hortonworks.com>>
Reply-To: Deepak Jaiswal <dj...@hortonworks.com>>
Date: Tuesday, June 27, 2017 at 14:45
To: Deepak Jaiswal <dj...@hortonworks.com>>
Cc: Sergey Shelukhin <se...@hortonworks.com>>, "dev@hive.apache.org<ma...@hive.apache.org>" <de...@hive.apache.org>>
Subject: Re: Review Request 60478: HIVE-16761 LLAP IO: SMB joins fail elevator
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60478/
Looks good to me. Can you please address one minor comment?
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java<https://reviews.apache.org/r/60478/diff/1/?file=1764267#file1764267line197>(Diff revision 1)
183
// TODO: try to find the fake merge work for SMB join, that is really another MapWork.
Why is this code block commented out? Is it not needed anymore?
- Deepak Jaiswal
On June 27th, 2017, 6:24 p.m. UTC, Sergey Shelukhin wrote:
Review request for hive and Deepak Jaiswal.
By Sergey Shelukhin.
Updated June 27, 2017, 6:24 p.m.
Repository: hive-git
Description
see jira
Diffs
* itests/src/test/resources/testconfiguration.properties (0aadee3e3d)
* llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java (c22d446320)
* llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java (d4e14a88c2)
* ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatchCtx.java (e546a658c7)
* ql/src/test/queries/clientpositive/llap_smb.q (PRE-CREATION)
* ql/src/test/results/clientpositive/llap/llap_smb.q.out (PRE-CREATION)
View Diff<https://reviews.apache.org/r/60478/diff/1/>
Re: Review Request 60478: HIVE-16761 LLAP IO: SMB joins fail elevator
Posted by Deepak Jaiswal <dj...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60478/#review179053
-----------------------------------------------------------
Looks good to me. Can you please address one minor comment?
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java
Lines 183 (patched)
<https://reviews.apache.org/r/60478/#comment253457>
Why is this code block commented out? Is it not needed anymore?
- Deepak Jaiswal
On June 27, 2017, 6:24 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60478/
> -----------------------------------------------------------
>
> (Updated June 27, 2017, 6:24 p.m.)
>
>
> Review request for hive and Deepak Jaiswal.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> itests/src/test/resources/testconfiguration.properties 0aadee3e3d
> llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java c22d446320
> llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d4e14a88c2
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatchCtx.java e546a658c7
> ql/src/test/queries/clientpositive/llap_smb.q PRE-CREATION
> ql/src/test/results/clientpositive/llap/llap_smb.q.out PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/60478/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>