You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/05/02 05:28:26 UTC
[kudu-CR] [tablet] update the severity level of some tablet metrics
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21384
Change subject: [tablet] update the severity level of some tablet metrics
......................................................................
[tablet] update the severity level of some tablet metrics
The motivation for this update was a request to provide information
on the number of rows returned by scanners run against a particular
tablet. That's to be on par with the following tablet metrics of the
MetricLevel::kInfo severity level:
* rows_inserted
* rows_updated
* rows_upserted
* rows_deleted
I also took the liberty of updating the level of some other tablet
metrics to make their severity level more consistent with the rest
of tablet metrics that have similar semantics.
Change-Id: If468eeef8488f4a28bdc23a2fc45073e4a3592d4
---
M src/kudu/tablet/tablet_metrics.cc
1 file changed, 18 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/21384/1
--
To view, visit http://gerrit.cloudera.org:8080/21384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If468eeef8488f4a28bdc23a2fc45073e4a3592d4
Gerrit-Change-Number: 21384
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [tablet] update the severity level of some tablet metrics
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21384 )
Change subject: [tablet] update the severity level of some tablet metrics
......................................................................
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If468eeef8488f4a28bdc23a2fc45073e4a3592d4
Gerrit-Change-Number: 21384
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 08 May 2024 11:33:54 +0000
Gerrit-HasComments: No
[kudu-CR] [tablet] update the severity level of some tablet metrics
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21384 )
Change subject: [tablet] update the severity level of some tablet metrics
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/81/
--
To view, visit http://gerrit.cloudera.org:8080/21384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If468eeef8488f4a28bdc23a2fc45073e4a3592d4
Gerrit-Change-Number: 21384
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 02 May 2024 05:28:35 +0000
Gerrit-HasComments: No
[kudu-CR] [tablet] update the severity level of some tablet metrics
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21384 )
Change subject: [tablet] update the severity level of some tablet metrics
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/103/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If468eeef8488f4a28bdc23a2fc45073e4a3592d4
Gerrit-Change-Number: 21384
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 05 May 2024 20:19:22 +0000
Gerrit-HasComments: No
[kudu-CR] [tablet] update the severity level of some tablet metrics
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21384 )
Change subject: [tablet] update the severity level of some tablet metrics
......................................................................
[tablet] update the severity level of some tablet metrics
The motivation for this update was a request to provide information
on the number of rows returned by scanners run against a particular
tablet. That's to be on par with the following tablet metrics of the
MetricLevel::kInfo severity level:
* rows_inserted
* rows_updated
* rows_upserted
* rows_deleted
I also took the liberty of updating the level of some other tablet
metrics to make their severity level more consistent with the rest
of tablet metrics that have similar semantics.
Change-Id: If468eeef8488f4a28bdc23a2fc45073e4a3592d4
Reviewed-on: http://gerrit.cloudera.org:8080/21384
Reviewed-by: Attila Bukor <ab...@apache.org>
Tested-by: Attila Bukor <ab...@apache.org>
---
M src/kudu/tablet/tablet_metrics.cc
1 file changed, 18 insertions(+), 18 deletions(-)
Approvals:
Attila Bukor: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If468eeef8488f4a28bdc23a2fc45073e4a3592d4
Gerrit-Change-Number: 21384
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tablet] update the severity level of some tablet metrics
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21384 )
Change subject: [tablet] update the severity level of some tablet metrics
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/103/
--
To view, visit http://gerrit.cloudera.org:8080/21384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If468eeef8488f4a28bdc23a2fc45073e4a3592d4
Gerrit-Change-Number: 21384
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 04 May 2024 00:41:33 +0000
Gerrit-HasComments: No
[kudu-CR] [tablet] update the severity level of some tablet metrics
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has removed a vote on this change.
Change subject: [tablet] update the severity level of some tablet metrics
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/21384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: If468eeef8488f4a28bdc23a2fc45073e4a3592d4
Gerrit-Change-Number: 21384
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tablet] update the severity level of some tablet metrics
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21384 )
Change subject: [tablet] update the severity level of some tablet metrics
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/81/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If468eeef8488f4a28bdc23a2fc45073e4a3592d4
Gerrit-Change-Number: 21384
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 02 May 2024 06:50:28 +0000
Gerrit-HasComments: No