You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/12 08:57:46 UTC
[GitHub] [spark] yaooqinn commented on a change in pull request #27876:
[SPARK-31119][SQL] Add interval value support for extract expression as
extract source
yaooqinn commented on a change in pull request #27876: [SPARK-31119][SQL] Add interval value support for extract expression as extract source
URL: https://github.com/apache/spark/pull/27876#discussion_r391477854
##########
File path: sql/core/benchmarks/ExtractBenchmark-jdk11-results.txt
##########
@@ -2,118 +2,137 @@ Java HotSpot(TM) 64-Bit Server VM 11.0.5+10-LTS on Mac OS X 10.15.3
Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
Invoke extract for timestamp: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-cast to timestamp 343 348 5 29.1 34.3 1.0X
-MILLENNIUM of timestamp 888 899 14 11.3 88.8 0.4X
-CENTURY of timestamp 835 846 15 12.0 83.5 0.4X
-DECADE of timestamp 824 834 9 12.1 82.4 0.4X
-YEAR of timestamp 818 824 10 12.2 81.8 0.4X
-ISOYEAR of timestamp 879 890 17 11.4 87.9 0.4X
-QUARTER of timestamp 965 1073 96 10.4 96.5 0.4X
-MONTH of timestamp 787 793 8 12.7 78.7 0.4X
-WEEK of timestamp 1277 1341 57 7.8 127.7 0.3X
-DAY of timestamp 780 785 8 12.8 78.0 0.4X
-DAYOFWEEK of timestamp 956 962 7 10.5 95.6 0.4X
-DOW of timestamp 995 1034 36 10.1 99.5 0.3X
-ISODOW of timestamp 885 898 11 11.3 88.5 0.4X
-DOY of timestamp 808 810 3 12.4 80.8 0.4X
-HOUR of timestamp 622 627 7 16.1 62.2 0.6X
-MINUTE of timestamp 629 636 8 15.9 62.9 0.5X
-SECOND of timestamp 800 819 30 12.5 80.0 0.4X
-MILLISECONDS of timestamp 743 755 21 13.5 74.3 0.5X
-MICROSECONDS of timestamp 692 730 53 14.5 69.2 0.5X
-EPOCH of timestamp 773 798 40 12.9 77.3 0.4X
+cast to timestamp 311 331 18 32.2 31.1 1.0X
+MILLENNIUM of timestamp 873 893 17 11.4 87.3 0.4X
+CENTURY of timestamp 869 873 5 11.5 86.9 0.4X
+DECADE of timestamp 851 872 23 11.7 85.1 0.4X
+YEAR of timestamp 841 856 14 11.9 84.1 0.4X
+ISOYEAR of timestamp 927 938 12 10.8 92.7 0.3X
+QUARTER of timestamp 959 963 6 10.4 95.9 0.3X
+MONTH of timestamp 852 864 18 11.7 85.2 0.4X
+WEEK of timestamp 1124 1252 112 8.9 112.4 0.3X
+DAY of timestamp 848 867 19 11.8 84.8 0.4X
+DAYOFWEEK of timestamp 977 987 16 10.2 97.7 0.3X
+DOW of timestamp 945 964 18 10.6 94.5 0.3X
+ISODOW of timestamp 924 929 5 10.8 92.4 0.3X
+DOY of timestamp 852 906 67 11.7 85.2 0.4X
+HOUR of timestamp 665 671 5 15.0 66.5 0.5X
+MINUTE of timestamp 655 670 15 15.3 65.5 0.5X
+SECOND of timestamp 757 763 7 13.2 75.7 0.4X
+MILLISECONDS of timestamp 745 761 14 13.4 74.5 0.4X
+MICROSECONDS of timestamp 691 697 7 14.5 69.1 0.5X
+EPOCH of timestamp 794 806 12 12.6 79.4 0.4X
Java HotSpot(TM) 64-Bit Server VM 11.0.5+10-LTS on Mac OS X 10.15.3
Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
Invoke date_part for timestamp: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
-cast to timestamp 303 323 24 33.0 30.3 1.0X
-MILLENNIUM of timestamp 841 852 9 11.9 84.1 0.4X
-CENTURY of timestamp 818 821 4 12.2 81.8 0.4X
-DECADE of timestamp 821 836 15 12.2 82.1 0.4X
-YEAR of timestamp 858 928 61 11.7 85.8 0.4X
-ISOYEAR of timestamp 933 939 6 10.7 93.3 0.3X
Review comment:
```
[info] ISOYEAR of timestamp 949 1031 73 10.5 94.9 0.2X
[info] QUARTER of timestamp 1065 1097 39 9.4 106.5 0.2X
```
with a new round result, I guess the results are random
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org