You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "tian-pengfei (via GitHub)" <gi...@apache.org> on 2023/05/05 13:45:21 UTC
[GitHub] [shenyu] tian-pengfei opened a new pull request, #4615: [ISSUE #4560] spring-mvc(boot) client support collect api-doc
tian-pengfei opened a new pull request, #4615:
URL: https://github.com/apache/shenyu/pull/4615
<!-- Describe your PR here; eg. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [x] You submit test cases (unit or integration tests) that back your changes.
- [x] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
Implements https://github.com/apache/shenyu/issues/4560
exmaple:
`@EnableClientRegister ` will enable api collect
```java
@SpringBootApplication
@EnableClientRegister
public class ShenyuTestHttpApplication {
/**
* main.
*
* @param args args
*/
public static void main(final String[] args) {
SpringApplication.run(ShenyuTestHttpApplication.class, args);
}
}
```
Collection rules
```java
@RestController
@RequestMapping("/oauth")
@ApiModule(value = "oauth")
public class OauthController {
/**
* Test oauth2 code request.
*
* @return String
*/
@GetMapping("/authorize")
@ApiDoc(desc = "authorize")
public String testCode() {
return "authorize";
}
}
```
`/oauth/authorize` will be collected ,`@ApiModule` and `@ApiDoc` must be present at the same time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #4615: [ISSUE #4560] spring-mvc(boot) client support collect api-doc
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4615:
URL: https://github.com/apache/shenyu/pull/4615#issuecomment-1537165417
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/4615?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4615](https://app.codecov.io/gh/apache/shenyu/pull/4615?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7cc0edb) into [master](https://app.codecov.io/gh/apache/shenyu/commit/cf506eb081c1cbf2435824f36b8842f1e148f063?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cf506eb) will **decrease** coverage by `0.27%`.
> The diff coverage is `9.25%`.
```diff
@@ Coverage Diff @@
## master #4615 +/- ##
============================================
- Coverage 67.63% 67.36% -0.27%
+ Complexity 7871 7867 -4
============================================
Files 1078 1084 +6
Lines 30775 30892 +117
Branches 2807 2813 +6
============================================
- Hits 20814 20811 -3
- Misses 8332 8452 +120
Partials 1629 1629
```
| [Impacted Files](https://app.codecov.io/gh/apache/shenyu/pull/4615?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/shenyu/client/core/register/ApiBean.java](https://app.codecov.io/gh/apache/shenyu/pull/4615?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvY29yZS9yZWdpc3Rlci9BcGlCZWFuLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ore/register/ClientInfoRefreshedEventListener.java](https://app.codecov.io/gh/apache/shenyu/pull/4615?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvY29yZS9yZWdpc3Rlci9DbGllbnRJbmZvUmVmcmVzaGVkRXZlbnRMaXN0ZW5lci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...client/core/register/ClientRegisterConfigImpl.java](https://app.codecov.io/gh/apache/shenyu/pull/4615?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvY29yZS9yZWdpc3Rlci9DbGllbnRSZWdpc3RlckNvbmZpZ0ltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...lient/core/register/matcher/ApiDocBeanMatcher.java](https://app.codecov.io/gh/apache/shenyu/pull/4615?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvY29yZS9yZWdpc3Rlci9tYXRjaGVyL0FwaURvY0JlYW5NYXRjaGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...core/register/matcher/ApiDocDefinitionMatcher.java](https://app.codecov.io/gh/apache/shenyu/pull/4615?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvY29yZS9yZWdpc3Rlci9tYXRjaGVyL0FwaURvY0RlZmluaXRpb25NYXRjaGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...egister/parser/AbstractApiDocDefinitionParser.java](https://app.codecov.io/gh/apache/shenyu/pull/4615?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvY29yZS9yZWdpc3Rlci9wYXJzZXIvQWJzdHJhY3RBcGlEb2NEZWZpbml0aW9uUGFyc2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...re/register/parser/HttpApiDocDefinitionParser.java](https://app.codecov.io/gh/apache/shenyu/pull/4615?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvY29yZS9yZWdpc3Rlci9wYXJzZXIvSHR0cEFwaURvY0RlZmluaXRpb25QYXJzZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../register/parser/NoHttpApiDocDefinitionParser.java](https://app.codecov.io/gh/apache/shenyu/pull/4615?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvY29yZS9yZWdpc3Rlci9wYXJzZXIvTm9IdHRwQXBpRG9jRGVmaW5pdGlvblBhcnNlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...henyuSpringMvcClientInfoRegisterConfiguration.java](https://app.codecov.io/gh/apache/shenyu/pull/4615?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItY2xpZW50L3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLWNsaWVudC1zcHJpbmdtdmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zcHJpbmdib290L3N0YXJ0ZXIvY2xpZW50L3NwcmluZ212Yy9TaGVueXVTcHJpbmdNdmNDbGllbnRJbmZvUmVnaXN0ZXJDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ster/apimeta/SpringMvcApiMetaDefinitionParser.java](https://app.codecov.io/gh/apache/shenyu/pull/4615?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdtdmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvc3ByaW5nbXZjL3JlZ2lzdGVyL2FwaW1ldGEvU3ByaW5nTXZjQXBpTWV0YURlZmluaXRpb25QYXJzZXIuamF2YQ==) | `86.11% <100.00%> (+0.39%)` | :arrow_up: |
| ... and [1 more](https://app.codecov.io/gh/apache/shenyu/pull/4615?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/4615/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] li-keguo merged pull request #4615: [ISSUE #4560] spring-mvc(boot) client support collect api-doc
Posted by "li-keguo (via GitHub)" <gi...@apache.org>.
li-keguo merged PR #4615:
URL: https://github.com/apache/shenyu/pull/4615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org