You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2023/01/30 16:12:01 UTC
[kudu-CR] [docs] Document data at rest encryption
Attila Bukor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19457
Change subject: [docs] Document data at rest encryption
......................................................................
[docs] Document data at rest encryption
Change-Id: If4d26f5cdd4e84af03d5d2070c1a1350defa2b49
---
M docs/security.adoc
1 file changed, 36 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/19457/1
--
To view, visit http://gerrit.cloudera.org:8080/19457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If4d26f5cdd4e84af03d5d2070c1a1350defa2b49
Gerrit-Change-Number: 19457
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
[kudu-CR] [docs] Document data at rest encryption
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19457 )
Change subject: [docs] Document data at rest encryption
......................................................................
Patch Set 5:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/19457/3/docs/security.adoc
File docs/security.adoc:
http://gerrit.cloudera.org:8080/#/c/19457/3/docs/security.adoc@488
PS3, Line 488: Kudu allows all communications among servers and between clients and servers
: to be encrypted with TLS,
> nit: maybe, add an extra sentence to this summary to mention that Kudu also
Done
http://gerrit.cloudera.org:8080/#/c/19457/3/docs/security.adoc@508
PS3, Line 508: physical
> physical
Done
http://gerrit.cloudera.org:8080/#/c/19457/3/docs/security.adoc@510
PS3, Line 510: the _
> This should be either 'a' or 'the'. Probably, 'the' is the better choice a
Done
http://gerrit.cloudera.org:8080/#/c/19457/3/docs/security.adoc@514
PS3, Line 514: Encryption at rest can be enabled with
> nit: to match the corresponding sentence from the 'Data in Transit' section
Done
http://gerrit.cloudera.org:8080/#/c/19457/3/docs/security.adoc@601
PS3, Line 601:
> nit: I guess the readers would appreciate to have a small commented explana
Done
--
To view, visit http://gerrit.cloudera.org:8080/19457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4d26f5cdd4e84af03d5d2070c1a1350defa2b49
Gerrit-Change-Number: 19457
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Jan 2023 22:20:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Document data at rest encryption
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/19457 )
Change subject: [docs] Document data at rest encryption
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4d26f5cdd4e84af03d5d2070c1a1350defa2b49
Gerrit-Change-Number: 19457
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Jan 2023 17:50:11 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Document data at rest encryption
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19457
to look at the new patch set (#2).
Change subject: [docs] Document data at rest encryption
......................................................................
[docs] Document data at rest encryption
Change-Id: If4d26f5cdd4e84af03d5d2070c1a1350defa2b49
---
M docs/security.adoc
1 file changed, 44 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/19457/2
--
To view, visit http://gerrit.cloudera.org:8080/19457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If4d26f5cdd4e84af03d5d2070c1a1350defa2b49
Gerrit-Change-Number: 19457
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [docs] Document data at rest encryption
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19457
to look at the new patch set (#3).
Change subject: [docs] Document data at rest encryption
......................................................................
[docs] Document data at rest encryption
Change-Id: If4d26f5cdd4e84af03d5d2070c1a1350defa2b49
---
M docs/security.adoc
1 file changed, 52 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/19457/3
--
To view, visit http://gerrit.cloudera.org:8080/19457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If4d26f5cdd4e84af03d5d2070c1a1350defa2b49
Gerrit-Change-Number: 19457
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [docs] Document data at rest encryption
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19457 )
Change subject: [docs] Document data at rest encryption
......................................................................
[docs] Document data at rest encryption
Change-Id: If4d26f5cdd4e84af03d5d2070c1a1350defa2b49
Reviewed-on: http://gerrit.cloudera.org:8080/19457
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M docs/security.adoc
1 file changed, 62 insertions(+), 13 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If4d26f5cdd4e84af03d5d2070c1a1350defa2b49
Gerrit-Change-Number: 19457
Gerrit-PatchSet: 6
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [docs] Document data at rest encryption
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19457 )
Change subject: [docs] Document data at rest encryption
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19457/1/docs/security.adoc
File docs/security.adoc:
http://gerrit.cloudera.org:8080/#/c/19457/1/docs/security.adoc@492
PS1, Line 492: Encryption
> nit: maybe change this to "Encryption in transit"
Done
http://gerrit.cloudera.org:8080/#/c/19457/1/docs/security.adoc@519
PS1, Line 519:
> Could you maybe provide and example tool, or an example command how to acce
Done
--
To view, visit http://gerrit.cloudera.org:8080/19457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4d26f5cdd4e84af03d5d2070c1a1350defa2b49
Gerrit-Change-Number: 19457
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Jan 2023 17:22:13 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Document data at rest encryption
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19457
to look at the new patch set (#4).
Change subject: [docs] Document data at rest encryption
......................................................................
[docs] Document data at rest encryption
Change-Id: If4d26f5cdd4e84af03d5d2070c1a1350defa2b49
---
M docs/security.adoc
1 file changed, 52 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/19457/4
--
To view, visit http://gerrit.cloudera.org:8080/19457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If4d26f5cdd4e84af03d5d2070c1a1350defa2b49
Gerrit-Change-Number: 19457
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [docs] Document data at rest encryption
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19457
to look at the new patch set (#5).
Change subject: [docs] Document data at rest encryption
......................................................................
[docs] Document data at rest encryption
Change-Id: If4d26f5cdd4e84af03d5d2070c1a1350defa2b49
---
M docs/security.adoc
1 file changed, 62 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/19457/5
--
To view, visit http://gerrit.cloudera.org:8080/19457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If4d26f5cdd4e84af03d5d2070c1a1350defa2b49
Gerrit-Change-Number: 19457
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [docs] Document data at rest encryption
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19457 )
Change subject: [docs] Document data at rest encryption
......................................................................
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/19457/3/docs/security.adoc
File docs/security.adoc:
http://gerrit.cloudera.org:8080/#/c/19457/3/docs/security.adoc@488
PS3, Line 488: Kudu allows all communications among servers and between clients and servers
: to be encrypted with TLS.
nit: maybe, add an extra sentence to this summary to mention that Kudu also supports data-at-rest encryption?
http://gerrit.cloudera.org:8080/#/c/19457/3/docs/security.adoc@508
PS3, Line 508: phsyical
physical
http://gerrit.cloudera.org:8080/#/c/19457/3/docs/security.adoc@510
PS3, Line 510: a the
This should be either 'a' or 'the'. Probably, 'the' is the better choice as I can see from the context.
http://gerrit.cloudera.org:8080/#/c/19457/3/docs/security.adoc@514
PS3, Line 514: Data at rest encryption can be enabled
nit: to match the corresponding sentence from the 'Data in Transit' section, maybe change this to 'Encryption at rest can be enabled ...'
http://gerrit.cloudera.org:8080/#/c/19457/3/docs/security.adoc@601
PS3, Line 601: #------------------------
nit: I guess the readers would appreciate to have a small commented explanation for the example below, similar to the text blurb for the coarse-grain authorization example above. If adding that, maybe it would be more natural to have example cluster name and example URL for Ranger KMS instead of placeholders.
--
To view, visit http://gerrit.cloudera.org:8080/19457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4d26f5cdd4e84af03d5d2070c1a1350defa2b49
Gerrit-Change-Number: 19457
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Jan 2023 18:39:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Document data at rest encryption
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19457 )
Change subject: [docs] Document data at rest encryption
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4d26f5cdd4e84af03d5d2070c1a1350defa2b49
Gerrit-Change-Number: 19457
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Jan 2023 22:35:14 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Document data at rest encryption
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/19457 )
Change subject: [docs] Document data at rest encryption
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19457/1/docs/security.adoc
File docs/security.adoc:
http://gerrit.cloudera.org:8080/#/c/19457/1/docs/security.adoc@492
PS1, Line 492: Encryption
nit: maybe change this to "Encryption in transit"
http://gerrit.cloudera.org:8080/#/c/19457/1/docs/security.adoc@519
PS1, Line 519: CLI tools
Could you maybe provide and example tool, or an example command how to access encrypted files directly?
--
To view, visit http://gerrit.cloudera.org:8080/19457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4d26f5cdd4e84af03d5d2070c1a1350defa2b49
Gerrit-Change-Number: 19457
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Jan 2023 17:05:20 +0000
Gerrit-HasComments: Yes