You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2017/05/10 15:21:27 UTC
Re: Review Request 49207: Added proto message definitions to support
appc runtime.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49207/#review174485
-----------------------------------------------------------
include/mesos/appc/spec.proto
Lines 51 (patched)
<https://reviews.apache.org/r/49207/#comment247647>
This should be called `environments` as we are permitting multiple via `repeated`.
- Till Toenshoff
On June 30, 2016, 6 a.m., Srinivas Brahmaroutu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49207/
> -----------------------------------------------------------
>
> (Updated June 30, 2016, 6 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-4778
> https://issues.apache.org/jira/browse/MESOS-4778
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added proto message definitions to support appc runtime.
>
>
> Diffs
> -----
>
> include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4
> include/mesos/slave/isolator.proto f17a3a4f167eb203709d7ebac3ade220ac8641ea
>
>
> Diff: https://reviews.apache.org/r/49207/diff/7/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Srinivas Brahmaroutu
>
>